Repository navigation
feat(wizard): ask before changing global agent settings - #614
Conversation
The global trust entry shared one question with the install, so declining it cancelled the install. It now has its own step, which explains why the entry is needed and how far it reaches, and defaults to no. Declining still installs.
|
@claude /review |
|
Claude finished @theCodeDrift's task in 3m 32s —— View job Review mode: incremental — read 0 prior review thread(s) before reviewing.
SummaryThis PR gives the global [New] Control flow traced and looks correct:
[New] Minor, non-blocking observation: in No correctness, security, or test-adequacy issues found. Test coverage for the new decline/cancel/accept/stale/already-present paths in Note: I wasn't able to resolve this session's actual CI job run URL (environment lookups were blocked), so I'm omitting the job-run link rather than guessing one. |
Declined the per-offer label padding note. Only one harness exists today, so no two labels can misalign; it's worth revisiting if a second harness joins the list. — AI Coding Agent |
The wizard asked one question for every settings edit, so saying no to the entry in
~/.claude/settings.jsoncancelled the whole install. Nobody could install Taskless and skip the edit outside their project. This gives that edit its own question.postmanlabs/postman-app-support#14370 is the motivation: an installer changing global agent config without a real opt-in. We already asked, but a question bundled with the install isn't much of a choice, and skipping costs little, because the launcher and pin keep working and the agent asks for approval more often.
What changes
SKIPPED (global):block. Cancelling the prompt still writes nothing.Unchanged:
init --no-interactiveand--jsonstill never write outside the project. The entry's text is the same, so no existing entry goes stale.Worth a look
agent-global-trust(287238c3)../.taskless/bin/cli.mjsin any repository someone clones. A manual probe on 2026-10-19 (one run) passed a launcher swapped to run another package. The prompt now says this; narrowing the entry would mark every existing entry stale, so it is left out of this PR.Verified with
pnpm typecheck,pnpm lintand the CLI suite, using mocked prompts. Not yet run in a real terminal.