Repository navigation
Conversation
jserv
reviewed
Oct 11, 2026
Contributor
|
@Ericko00o #256 merged on 2026-10-11, so the prerequisite this draft waits on is in |
Ericko00o
force-pushed
the
feat/preserve-random-draw
branch
from
October 13, 2026 03:37
ff67108 to
3bef5c8
Compare
Ericko00o
marked this pull request as ready for review
October 13, 2026 03:38
jserv
requested changes
Oct 13, 2026
jserv
left a comment
Contributor
There was a problem hiding this comment.
Rebase latest main branch and resolve conflicts.
An unfinished interview should retain the draw and lobby choices taken when Start was pressed, even when sign-in delays navigation. Restore those choices across Back, Leave, and Done without letting later edits replace the ticket. Only the latest successfully saved graded report may end a draw; retained older reports cannot prove completion after a failed save. Clearing a topic returns to recommendations.
Ericko00o
force-pushed
the
feat/preserve-random-draw
branch
from
October 14, 2026 11:01
3bef5c8 to
edecbee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve an explicit random draw and the candidate's difficulty and duration choices when returning from an unfinished interview through Back, Leave, or Done. Capture the draw ticket and lobby snapshot when Start is pressed so picker changes during an awaited sign-in cannot replace the interview's selection. Reapply the captured choices after native browser form restoration. Clearing a topic filter returns to recommendations while retaining the explicit lobby choices.
Save a tab-local snapshot alongside the draw ticket for fresh lobby entries. Only the latest successfully persisted graded HIRE or NO_HIRE report may end that draw. Beginning a new save invalidates previous completion, so pending, rejected, and failed saves cannot reuse a retained older report. Interview URLs without a ticket cannot claim another draw, and unrelated report deletion or account-history merges retain the selection.
When sessionStorage is unavailable, a ticket-specific same-origin localStorage receipt records the current save outcome and must match the persisted report. Receipts from another tab cannot replace this draw's result. Read-only storage cannot establish a current completion and is treated conservatively. Browser Back uses history state when tab storage is blocked; a fresh lobby entry requires available tab storage to restore the snapshot. If neither completion store is usable, retain the draw instead of inferring success from old history.
Validation: all 237 targeted picker, lobby, draw-completion, and interview-lifecycle tests passed without failures or skips. The login-race and newer-failed-save cases failed before the fixes and passed afterward. Formatting, ESLint, commit-message validation, staged checks, and all 49 Git hooks checks passed. The full browser suite reported 1192 passed, 5 failed, and 3 skipped. The required scripts/test.sh gate was run but did not pass: Cargo was unavailable; wire-fixtures and recording-provision-check-tests encountered existing Windows limitations; the five browser failures were four Windows ESM path cases and one unavailable-server face check. Java and two built-server browser cases were skipped, and cargo-audit, actionlint, ruff, and shellcheck were unavailable.
Rebased onto main at 8394d54. This PR contains one navigation commit and preserves upstream source-display, interview retry settings, and voice controls.