Skip to content

fix: fire-forget domain version update - #589

Merged
petruki merged 1 commit into
masterfrom
staging
Oct 6, 2026
Merged

petruki merged 1 commit into
masterfrom
staging

Conversation

@petruki

@petruki petruki commented Oct 6, 2026

Copy link
Copy Markdown
Member

This pull request updates how the updateDomainVersion function is called across several service files. Instead of awaiting the completion of updateDomainVersion, the function is now invoked in a fire-and-forget manner using the void operator. This change ensures that the main flow of each service function is not blocked by the domain version update, potentially improving performance and responsiveness.

Service logic changes:

Performance and flow improvements:

  • By not awaiting updateDomainVersion, service methods now return earlier, which can reduce latency for API endpoints and background jobs that rely on these service calls. [1] [2] [3] [4]

Consistency:

  • This pattern is now consistently applied across all service functions that update the domain version, improving codebase uniformity. [1] [2] [3] [4]

@petruki petruki added this to the v1.4.1 milestone Oct 6, 2026
@petruki petruki self-assigned this Oct 6, 2026
@petruki petruki added enhancement New feature or request patch Updating dependencies labels Oct 6, 2026
@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2026

Copy link
Copy Markdown

@petruki
petruki merged commit 5fed13b into master Oct 6, 2026
5 checks passed
@petruki
petruki deleted the staging branch October 6, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request patch Updating dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant