Repository navigation
avoid type values in bsup package - #7605
Merged
Merged
Conversation
mccanne
approved these changes
Nov 4, 2026
mccanne
left a comment
mccanne
left a comment
Collaborator
There was a problem hiding this comment.
Way better. One more big move to make along with DFS locators.
Type values can be large and can bloat a super.Context when interned by its LookupByValue, LookupTypeValue, and TranslateType methods. Avoid them by replacing type values with type IDs from a super.TypeDefs when one is available (i.e., everywhere but bsup.SuperFooter). This includes a change of the BSUP version to 0.29.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type values can be large and can bloat a super.Context when interned by its LookupByValue, LookupTypeValue, and TranslateType methods. Avoid them by replacing type values with type IDs from a super.TypeDefs when one is available (i.e., everywhere but bsup.SuperFooter).
This includes a change of the BSUP version to 0.29.