Repository navigation
feat: debug info - #27
AndrewJackson2020 wants to merge 2 commits into
Conversation
| # get debug line numbers into binaries | ||
| for f in $out/bin/*; do | ||
| dsymutil "$f" | ||
| done |
There was a problem hiding this comment.
Could you elaborate on why is this needed?
There was a problem hiding this comment.
My understanding (sourced entirely from Claude) is that on Macos/Clang symbols in binaries really just means keep a map in the binary to the corresponding .o file which contains the actual line number information. Once the .o files are removed all line level debug info is gone. This is needed because it modifies the binary to store all of the line number info together with the binary.
That said this is all new to me and I'm open to better ways go doing this.
There was a problem hiding this comment.
Hm, but have you confirmed this is necessary?
Ideally we'd have some sort of test for this but a manual test would do fine.
There was a problem hiding this comment.
I can confirm it was not working before I input those lines and it was working after I input those lines. Agreed a real test would be better, in fact our UBSAN/ASAN tests caught a regression when I tried implementing this functionality. I'm not a huge fan as to how our tests work currently though (each assertion is a single step in a gh action pipeline).
No description provided.