Skip to content

refactor: strict qualification - #84

Merged
AndrewJackson2020 merged 1 commit into
mainfrom
strict_qualification
Nov 18, 2026
Merged

AndrewJackson2020 merged 1 commit into
mainfrom
strict_qualification

Conversation

@AndrewJackson2020

@AndrewJackson2020 AndrewJackson2020 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

This PR uses the latest development head of plpgsql_check to test out the strict schema qualification of referenced objects in functions. For demonstration purposes I have set it to mode 4 meaning every function, type, and operator must be schema qualified. There is some degradation in readability but the increase in security is may be worth it.

Interestingly TIL not all functions have schemas. coalesce for example. I believe that these are being flagged as false positives. I need to follow up with the maintainers if that is in fact that case.

@AndrewJackson2020

Copy link
Copy Markdown
Contributor Author

Tests are fine, macOS CI is going to fail until the below PR gets merged.

#85

@AndrewJackson2020
AndrewJackson2020 force-pushed the strict_qualification branch 3 times, most recently from 1cc1a2d to 5ee9813 Compare November 12, 2026 15:49
@AndrewJackson2020
AndrewJackson2020 marked this pull request as ready for review November 12, 2026 17:05
@AndrewJackson2020
AndrewJackson2020 requested a review from a team as a code owner November 12, 2026 17:05
@AndrewJackson2020 AndrewJackson2020 changed the title fix: strict qualification refactor: strict qualification Nov 16, 2026
@AndrewJackson2020

Copy link
Copy Markdown
Contributor Author

@mkaruza Thank you for the review. Will merge once rebased and tests pass.

@mkaruza
mkaruza self-requested a review November 16, 2026 15:47
@AndrewJackson2020

AndrewJackson2020 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor Author

Actually looking at this PR again, I think I want to wait until either:

  1. plpgsql_check cuts an official release
    or
  2. we find an issue that would be fixed by these changes

before merging these changes.

@AndrewJackson2020
AndrewJackson2020 merged commit edd9ef9 into main Nov 18, 2026
14 checks passed
@AndrewJackson2020
AndrewJackson2020 deleted the strict_qualification branch November 18, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants