Repository navigation
feat: read only GUC to expose pg_net version - #339
Open
AndrewJackson2020 wants to merge 4 commits into
Open
AndrewJackson2020 wants to merge 4 commits into
AndrewJackson2020 wants to merge 4 commits into
Conversation
steve-chavez
approved these changes
Nov 18, 2026
| expected_warnings = (1 if get_pg_version(conn) < 160000 else 0) | ||
|
|
||
| assert len(conn.execute(sql).fetchall()) == expected_warnings | ||
|
|
Contributor
There was a problem hiding this comment.
This needs to be changed on every release right? May be we can come up with other way to assert this? From the makefile version ?
Contributor
Author
There was a problem hiding this comment.
Agree, will not merge until this is DRY'd out. Also need to fix pg_catalog.pg_get_loaded_modules() in all 3 extensions as well, that will be included in this PR.
Will wait for your approval before merging.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a read only GUC that allows users and administrators to verify the binary version of the extension. Starting with pg18 this functionality will no longer be needed as postgres provides an interface to access this information natively. This PR corresponds with a previous PR in supautils linked below [0]. There is also a corresponding PR to get this implemented in supabase_vault [1] as well.
[0] supabase/supautils#252
[1] supabase/vault#87