Skip to content

feat: read only GUC to expose pg_net version - #339

Open
AndrewJackson2020 wants to merge 4 commits into
masterfrom
add_version_guc
Open

AndrewJackson2020 wants to merge 4 commits into
masterfrom
add_version_guc

Conversation

@AndrewJackson2020

@AndrewJackson2020 AndrewJackson2020 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

This PR adds a read only GUC that allows users and administrators to verify the binary version of the extension. Starting with pg18 this functionality will no longer be needed as postgres provides an interface to access this information natively. This PR corresponds with a previous PR in supautils linked below [0]. There is also a corresponding PR to get this implemented in supabase_vault [1] as well.

[0] supabase/supautils#252
[1] supabase/vault#87

Comment thread test/test_misc.py
expected_warnings = (1 if get_pg_version(conn) < 160000 else 0)

assert len(conn.execute(sql).fetchall()) == expected_warnings

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be changed on every release right? May be we can come up with other way to assert this? From the makefile version ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, will not merge until this is DRY'd out. Also need to fix pg_catalog.pg_get_loaded_modules() in all 3 extensions as well, that will be included in this PR.

Will wait for your approval before merging.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants