Repository navigation
docs: document columns left out of insert and update inputs - #666
Open
Indian-boult wants to merge 1 commit into
Open
Indian-boult wants to merge 1 commit into
Indian-boult wants to merge 1 commit into
Conversation
serial, identity and generated columns are not part of the <Table>InsertInput and <Table>UpdateInput types, so their values always come from PostgreSQL. Say so in the Insert and Update sections of the API docs, and say when a column with a nextval default stays in. Fixes supabase#501
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #501
The Insert and Update sections of
docs/api.mdnow say thatserial, identity and generated columns are left out of<Table>InsertInputand<Table>UpdateInput. They also say that a column with anextvaldefault on a sequence created by hand stays in, unless the column owns that sequence.I checked this on PostgreSQL 17 against pg_graphql built from current master. I made a table with one column of each kind and looked at the input types with
__typeintrospection, then ran insert and update mutations throughgraphql.resolve.mkdocs build --strictpasses.