Repository navigation
fix: make the message bus public in the installer - #465
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe install environment now exposes the default Messenger bus through the public MessageBusInterface alias, preventing the MediaLibrary installer from failing when it retrieves the bus during a fresh installation. Sequence diagram for MediaLibrary installation message bus lookupsequenceDiagram
participant Installer as MediaLibrary_Installer
participant Container as Install_Container
participant Bus as messenger.bus.default
participant Handler as CreateMediaFolder_Handler
Installer->>Container: Model::get(MessageBusInterface::class)
Container->>Bus: resolve public alias
Installer->>Bus: dispatch(CreateMediaFolder)
Bus->>Handler: handle(CreateMediaFolder)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
tijsverkoyen
approved these changes
Nov 2, 2026
Member
Author
|
Tested end-to-end: a full install (multilanguage, 5 languages, stock modules incl. the required MediaLibrary) now completes, where it previously failed on the MediaLibrary step with the MessageBusInterface error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh install fails on the MediaLibrary module:
MediaLibrary\Installer\Installer::loadMediaFolders()fetches the bus withModel::get(MessageBusInterface::class).config.ymlmakes that alias public, but the install kernel only loadsconfig_install.yml, where the alias stays private. MediaLibrary is a required module, so every new install hits this.This adds the same public alias to
config_install.yml.Checked with
bin/console --env=install debug:container(alias is public) anddebug:messenger(CreateMediaFolderhandler is registered in the install env).Summary by Sourcery
Bug Fixes: