Skip to content

fix: make the message bus public in the installer - #465

Merged
jonasdekeukelaere merged 1 commit into
masterfrom
fix/installer-message-bus
Nov 2, 2026
Merged

jonasdekeukelaere merged 1 commit into
masterfrom
fix/installer-message-bus

Conversation

@jonasdekeukelaere

@jonasdekeukelaere jonasdekeukelaere commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

A fresh install fails on the MediaLibrary module:

The "Symfony\Component\Messenger\MessageBusInterface" service or alias has been removed or inlined when the container was compiled.

MediaLibrary\Installer\Installer::loadMediaFolders() fetches the bus with Model::get(MessageBusInterface::class). config.yml makes that alias public, but the install kernel only loads config_install.yml, where the alias stays private. MediaLibrary is a required module, so every new install hits this.

This adds the same public alias to config_install.yml.

Checked with bin/console --env=install debug:container (alias is public) and debug:messenger (CreateMediaFolder handler is registered in the install env).

Summary by Sourcery

Bug Fixes:

  • Fix fresh-install failures in the MediaLibrary step by making the Symfony Messenger message bus available through the install container.

@sourcery-ai

sourcery-ai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The install environment now exposes the default Messenger bus through the public MessageBusInterface alias, preventing the MediaLibrary installer from failing when it retrieves the bus during a fresh installation.

Sequence diagram for MediaLibrary installation message bus lookup

sequenceDiagram
    participant Installer as MediaLibrary_Installer
    participant Container as Install_Container
    participant Bus as messenger.bus.default
    participant Handler as CreateMediaFolder_Handler

    Installer->>Container: Model::get(MessageBusInterface::class)
    Container->>Bus: resolve public alias
    Installer->>Bus: dispatch(CreateMediaFolder)
    Bus->>Handler: handle(CreateMediaFolder)
Loading

File-Level Changes

Change Details Files
Expose the Messenger bus alias in the installation service container so MediaLibrary can resolve it during fresh installs.
  • Add a public alias from MessageBusInterface to messenger.bus.default in the install-only configuration.
  • Keep the change scoped to config_install.yml because the regular configuration is not loaded by the install kernel.
app/config/config_install.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@jonasdekeukelaere
jonasdekeukelaere merged commit 28b2abf into master Nov 2, 2026
9 of 12 checks passed
@jonasdekeukelaere

Copy link
Copy Markdown
Member Author

Tested end-to-end: a full install (multilanguage, 5 languages, stock modules incl. the required MediaLibrary) now completes, where it previously failed on the MediaLibrary step with the MessageBusInterface error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants