Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logsrvdgenerates relative log IDs using the length ofiolog_base, derived from the configured directory. Path expansion can shorten that directory by collapsing%%, collapsing repeated leading slashes, or removing trailing slashes. This mismatch can produce an incorrect relative path or an out-of-bounds read during log-ID generation.Stop the base at a directory boundary before the first
%escape and normalize its leading and trailing slashes consistently with path expansion. Keep expanded components in the relative log ID so reconnects reconstruct the correct path.Add regression coverage for literal percent escapes, date and named escapes, repeated slashes, and root directories. Tests verify base extraction, offset bounds, and reconnect path reconstruction.