Conversation
Share one sample traversal between the vtable callback and the private calibration pass. Keep calibration results typed and cache the ppo2 source on the parser. Signed-off-by: Michael Keller <github@ike.ch>
The calibration pass only produces CCR and SCR state, so skip it for open-circuit, gauge, and freedive profiles. Signed-off-by: Michael Keller <github@ike.ch>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Refactors Shearwater sample traversal to separate calibration preprocessing and cache ppO2 source state.
Changes:
- Adds parser-owned ppO2 source tracking.
- Restricts calibration prepasses to CCR/SCR dives.
- Separates internal traversal from the public callback wrapper.
File summaries
| File | Description |
|---|---|
src/shearwater_predator_parser.c |
Implements the traversal refactor and calibration prepass. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the Shearwater sample traversal into a shared internal implementation, a typed private calibration pre-pass, and the vtable callback wrapper.
The calibration pass no longer reinterprets callback userdata. Its ppO2 source state is cached on the parser, and the pass now runs only for CCR and SCR dives.
Tested with:
make -j2test/run-parse.sh