Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, a small nit from a loyal user of an otherwise flawless app. Thanks for building Standard Notes!
Problem
On macOS, clicking the close button while the window is in fullscreen doesn't hide the window. It exits fullscreen and stays visible in windowed mode.
Cause
The
closehandler callswindow.setFullScreen(false)followed immediately bywindow.hide(). On macOS, leaving fullscreen is asynchronous (it runs the Space transition animation), sohide()runs mid-transition and has no effect.Fix
When the window is fullscreen, wait for the
leave-full-screenevent before callinghide(). The window's opacity is also set to 0 before exiting fullscreen (and restored after hiding), so the user doesn't see it shrink to windowed mode before it disappears. This is closer to how native macOS apps behave. Non-fullscreen closes are unchanged.Testing
Tested on macOS (Apple Silicon) with a local build: