Repository navigation
Conversation
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 16:38
62baca3 to
83ecbc2
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 16:40
83ecbc2 to
bce6f35
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 16:54
bce6f35 to
ab5eb13
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 17:09
ab5eb13 to
52bf074
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 17:14
52bf074 to
89ffcbe
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 17:22
89ffcbe to
ed08880
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 17:34
ed08880 to
a565080
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 17:42
a565080 to
63db9e4
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 18:04
63db9e4 to
7120b33
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 18:20
7120b33 to
785fea6
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 19:05
5fdbbbe to
32182bc
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 19:19
32182bc to
ce67387
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 19:28
ce67387 to
fd39fb6
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 19:39
fd39fb6 to
6426343
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 19:48
6426343 to
6698028
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 20:10
6698028 to
5a44b97
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 20:23
5a44b97 to
38fa17d
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 20:52
38fa17d to
2dcccbb
Compare
reka18
force-pushed
the
fix/durable-checkpoint-cadence
branch
from
November 5, 2026 21:02
2dcccbb to
b3d0e06
Compare
Contributor
Author
|
Review results. One reviewer per dimension, each reading the others' findings. All seven dimensions have zero blockers on the latest round. Fixed along the way: a test the new cadence had stopped exercising now pins a non-empty tail, and the Known limit: |
A tick barrier spans several step ordinals, so WithCheckpointEvery could miss its multiple forever and the tail grew without limit. A checkpoint now lands on any step that crosses a boundary. Relates to #214. Signed-off-by: Ray Karnes <ray.karnes@stablekernel.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this change does
A checkpoint now lands on any step that crosses a
WithCheckpointEveryboundary. Stacked on #236. This is the top of the #214 chain.Such an instance now compacts, so on a Store without
HistoryStore,StateAtcan't reach the steps before its latest checkpoint. It answers with the checkpoint's state, orErrStepOutOfRangewhen the checkpoint left the tail empty, as it already did for a run of Fires. The cadence is unchanged for plain steps. ATickrecord can now checkpoint on a step other than the usual one.Why
A
Tickrecord spans several step ordinals, so it could miss the interval forever and the tail grew without limit. A review of #232 found this. It isn't listed in #214.Still open in #214 after this chain: telemetry on replay (question 7), which #214 defers, and the machine version opt-in (question 6). Questions 3 and 4 need a ruling.
Relates to: #214
Evidence
On
GOTOOLCHAIN=go1.27.3, indurable:go test ./...TestTimerCheckpoint_BarriersCannotStepOverTheIntervalis new, and it fails on the previous commit with a 52-record tailgo test -race ./...golangci-lintgo test ./...instate,cluster,e2e,transport,source,examples/dispatch,examples/fooddeliveryChecklist
git commit -s) per the DCOtype: subject)mage checkpasses locally (lint + race tests + govulncheck): not run as a whole