Skip to content

feat(inspect): ask for the tier when run has no --tier - #42

Merged
joshua-temple merged 4 commits into
mainfrom
fix/inspect-tier-prompt
Nov 8, 2026
Merged

joshua-temple merged 4 commits into
mainfrom
fix/inspect-tier-prompt

Conversation

@joshua-temple

Copy link
Copy Markdown
Collaborator

TLDR

  • run with no --tier now asks T0 or T1 in an interactive terminal
  • No terminal, and start always: exit 2, E_TIER_REQUIRED, names --tier T0|T1
  • A T1 pick is not Gate B consent; Gate A and Gate B unchanged

Why

  • Before: no --tier failed with tier (none) is not available in this version (exit 2), which reads like a missing feature
  • A person picks the tier; agents and pipes never get a default

Evidence

Case Test
no TTY, run run with no --tier and no terminal: usage error naming --tier, no run created
start in a TTY start with no --tier is refused even in a terminal: no worker, no run
piped stdin to bin piped stdin to the bin is refused at once, never read as a tier
t0 typed terminal: the menu names both tiers; t0 (any case) runs the scan only
T1 not consent terminal: a wrong answer asks again; T1 is not Gate B consent
3 bad answers terminal: three wrong or empty answers stop with no run created
Ctrl-D terminal: input that ends (Ctrl-D) stops at once with no run created
--tier no value --tier with no value is a usage error, not a prompt
help text bin --help exits 0 as a child process
  • Suite: 652 pass, 0 fail; lint clean; visual 42 pass; dry run --require-node20 passed

How to Verify

  1. In a terminal, run the command below; type x, then t0
  2. Expect not x., a second ask, then a T0 report
  3. echo T0 | shrine-inspect run exits 2 with E_TIER_REQUIRED
  4. shrine-inspect start exits 2 with E_TIER_REQUIRED
cd inspect && node bin/shrine-inspect.mjs run --no-history

- interactive terminal: T0/T1 menu, re-asks up to 3 times, Ctrl-D stops
- no terminal, and start always: E_TIER_REQUIRED (exit 2) names --tier
- a T1 pick is not Gate B consent; a T0 pick records Gate B by prompt
- --tier with no value is a usage error
@joshua-temple
joshua-temple merged commit dca7f1b into main Nov 8, 2026
8 checks passed
@joshua-temple
joshua-temple deleted the fix/inspect-tier-prompt branch November 8, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant