[Rushaway]

Stale command classes after !reload

Why: CommandHandler imported BaseCommand, Say and VoiceTrigger by name. Reload() re-executes torchlight.Commands, but Setup() then walked __subclasses__() on the old class objects, which those names kept alive. Every !reload re-instantiated the pre-reload classes, so code changes in Commands.py were never picked up.

Fix: Setup() resolves the classes through the module object (Commands.BaseCommand.__subclasses__(), Commands.VoiceTrigger..., Commands.Say...). Discovery semantics are unchanged (direct subclasses of BaseCommand plus subclasses of VoiceTrigger and Say, sorted by order desc). BaseCommand is now a typing-only import, so nothing at module level pins the first generation of classes. After a reload the old classes and old command instances are garbage-collectable.

Removed voice triggers survived !reload

Why: TriggerManager.Load() wrote into the existing self.voice_triggers and never cleared it, so triggers removed from triggers.json stayed active. sound_path was only read in __init__.

Fix: Load() builds triggers_dict, voice_triggers and the sound path into locals and swaps them in at the end. Removed triggers disappear, a malformed triggers.json (ConfigError) leaves the previous triggers intact, and Sounds.Path is re-read on every load.

Advertiser config not refreshed / config loaded twice

Why: OnReload refreshed anti_spam.config but not advertiser.config. It also re-read config.json, which Torchlight.Reload() had just done.

Fix: OnReload also refreshes audio_manager.advertiser.config and no longer calls config.load(). Torchlight.Reload() stays the only place config.json is re-read on reload, so a malformed config.json still raises ConfigError to the !reload caller before any OnReload state is swapped.

Persistent caches still live outside Commands.py (GeoIP.py is untouched).

Test plan

I ran a throwaway script (not committed) against a temp copy of config/, with the real Config, Torchlight, AudioManager, AccessManager, TriggerManager, SourcemodConfig and CommandHandler. It ran the full Torchlight.Reload() → OnReload path on origin/master and on this branch:

Check	master	this PR
type(cmd) is Commands.<Name> for every command after reload	False	True
Same set of 24 commands loaded after reload	True	True
config.load() calls per reload	2	1
Trigger removed from triggers.json gone from voice_triggers and VoiceTrigger.triggers	False	True
Sounds.Path change picked up	False	True
advertiser.config refreshed	False	True
Old class (weakref) collected after gc.collect()	False	True
Old command instances collected	True	True
Malformed triggers.json → ConfigError, previous triggers kept	True	True
Malformed config.json → ConfigError propagates from Torchlight.Reload()	True	True

• ruff check ., ruff format --check ., mypy: no new errors. The only errors left are the known baseline ones (UP041 in FFmpegAudioPlayer.py, FlareSolverr.py:29), which CI: Python Linting is red on master since the Python 3.12 bump (ruff UP041, mypy arg-type) #178 fixes.

No VERSION bump (batch policy, see #177).

Closes #189
Part of #177

🤖 Generated with Claude Code