Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 73 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
# (THREAT_MODEL.md §6.6 T-SC3).
permissions: {}

env:
RUSTFLAGS: ""
CARGO_INCREMENTAL: "0"

jobs:
check:
name: Cargo check & clippy
Expand All @@ -20,10 +24,10 @@ jobs:
with:
persist-credentials: false

- name: Install Rust 1.88
- name: Install Rust 1.89
uses: dtolnay/rust-toolchain@3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 # master@2026-05-27
with:
toolchain: "1.88"
toolchain: "1.89"
components: clippy

- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
Expand Down Expand Up @@ -65,10 +69,10 @@ jobs:
with:
persist-credentials: false

- name: Install Rust 1.88
- name: Install Rust 1.89
uses: dtolnay/rust-toolchain@3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 # master@2026-05-27
with:
toolchain: "1.88"
toolchain: "1.89"
targets: ${{ matrix.target }}

- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
Expand Down Expand Up @@ -168,10 +172,10 @@ jobs:
with:
persist-credentials: false

- name: Install Rust 1.88
- name: Install Rust 1.89
uses: dtolnay/rust-toolchain@3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 # master@2026-05-27
with:
toolchain: "1.88"
toolchain: "1.89"

- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2

Expand All @@ -195,10 +199,10 @@ jobs:
with:
persist-credentials: false

- name: Install Rust 1.88
- name: Install Rust 1.89
uses: dtolnay/rust-toolchain@3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 # master@2026-05-27
with:
toolchain: "1.88"
toolchain: "1.89"

- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2

Expand All @@ -220,7 +224,7 @@ jobs:
# Runs the local fake-lightwalletd tests. Real-node cases remain ignored
# unless a provisioned regtest harness is explicitly supplied.
- name: cargo test (local argos-network integration)
run: cargo test -p argos-core --features argos-network --test regtest_integration
run: cargo test -p argos-core --features argos-network --locked --test regtest_integration --test nu7_readiness

- name: Install Node for GUI interaction tests
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
Expand All @@ -238,6 +242,63 @@ jobs:
npx playwright install --with-deps chromium
npm run test:layout

nu7-node-tests:
name: NU7 block and proxy boundary
runs-on: ubuntu-latest
timeout-minutes: 45
permissions:
contents: read
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
with:
persist-credentials: false

# This action has no release tag for the reviewed 2026-03-27 commit.
# Keep the immutable pin; the requested Rust version is explicit below.
- name: Install Rust 1.89
uses: dtolnay/rust-toolchain@3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9
with:
toolchain: "1.89"

# Reviewed 2026-03-12 commit; the moving v2 tag has since advanced.
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32

- name: Install protoc
timeout-minutes: 10
run: bash scripts/install-ci-apt-deps.sh protobuf-compiler

# Independent volumes and a short chain qualify branch/block/proxy
# compatibility. Funded supported sweep/PCZT remains a release gate.
- name: Start independent NU7 boundary nodes
working-directory: tests/regtest
run: |
docker compose --profile nu7-fast up -d zebrad-nu7-fast lightwalletd-nu7-fast
for i in $(seq 1 60); do
if curl -sf --max-time 2 -H 'content-type: application/json' \
--data '{"jsonrpc":"2.0","id":"ci","method":"getblockcount","params":[]}' \
http://127.0.0.1:18262/ >/dev/null; then
echo "NU7 node accepted RPC after ${i}s"
ARGOS_NU7_PROFILE=fast ./nu7.sh before
exit 0
fi
sleep 1
done
echo "NU7 node did not accept RPC within the startup budget"
exit 1

- name: NU7 actual block and proxy boundary tests
run: |
set -o pipefail
cargo test -p argos-core --features argos-network --locked --test nu7_readiness \
private_ -- --ignored --nocapture --test-threads=1 2>&1 | tee nu7-node-test.log
passed=$(grep -cE '^test .* \.\.\. ok$|^ok$' nu7-node-test.log || true)
test "$passed" -eq 2

- name: Node logs on failure
if: failure()
working-directory: tests/regtest
run: docker compose --profile nu7-fast logs --tail=200 zebrad-nu7-fast lightwalletd-nu7-fast

cargo-deny:
name: Cargo deny (advisories + bans + licenses + sources)
runs-on: ubuntu-latest
Expand All @@ -263,10 +324,10 @@ jobs:
with:
persist-credentials: false

- name: Install Rust 1.88
- name: Install Rust 1.89
uses: dtolnay/rust-toolchain@3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 # master@2026-05-27
with:
toolchain: "1.88"
toolchain: "1.89"

- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2

Expand All @@ -275,6 +336,6 @@ jobs:

# `--locked` uses the committed imports.lock; no network for fresh
# import resolution. Refreshing the imports is a deliberate local
# action (`cargo vet update-imports`) so an upstream rewrite of any
# action (`cargo vet regenerate imports`) so an upstream rewrite of any
# imported audits.toml cannot silently change our trust set.
- run: cargo vet --locked
16 changes: 10 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ on:
# third-party Action token-exfiltration risk (THREAT_MODEL.md §6.6 T-SC3).
permissions: {}

env:
RUSTFLAGS: ""
CARGO_INCREMENTAL: "0"

jobs:
build-linux:
runs-on: ubuntu-22.04
Expand All @@ -54,10 +58,10 @@ jobs:
with:
persist-credentials: false

- name: Install Rust 1.88
- name: Install Rust 1.89
uses: dtolnay/rust-toolchain@3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 # master@2026-05-27
with:
toolchain: "1.88"
toolchain: "1.89"

# No Swatinem/rust-cache in release builds: a poisoned cache from a PR
# run feeding a signed release tag is a worse failure mode than a slow
Expand Down Expand Up @@ -124,10 +128,10 @@ jobs:
with:
persist-credentials: false

- name: Install Rust 1.88
- name: Install Rust 1.89
uses: dtolnay/rust-toolchain@3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 # master@2026-05-27
with:
toolchain: "1.88"
toolchain: "1.89"
# Both arches are needed: the universal-apple-darwin bundle lipo-joins
# an aarch64 and an x86_64 build into one fat binary.
targets: aarch64-apple-darwin, x86_64-apple-darwin
Expand Down Expand Up @@ -194,10 +198,10 @@ jobs:
with:
persist-credentials: false

- name: Install Rust 1.88
- name: Install Rust 1.89
uses: dtolnay/rust-toolchain@3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 # master@2026-05-27
with:
toolchain: "1.88"
toolchain: "1.89"

# No Swatinem/rust-cache in release builds — see Linux job above.

Expand Down
18 changes: 15 additions & 3 deletions CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ file produces, so the scan and sweep paths cannot tell the two apart. CLI
`--sapling-key-file` (a file, never a flag — a spending key in argv lands in
shell history and `ps`); GUI a paste field on the wallet screen. Both are
combinable with a wallet file and deduplicate against it. The human-readable prefixes come from
`zcash_protocol::constants`, so there is no unverifiable-constant caveat —
`zcash_keys::constants`, so there is no unverifiable-constant caveat —
but the test pinning them to the ZIP-32 literals stays, so an upstream rename
cannot silently move Argos off the prefix users hold. Viewing keys
(`zxviews…`) are deliberately refused: they would show a balance that cannot
Expand Down Expand Up @@ -157,8 +157,8 @@ direct recovery path and may produce a separate transaction.

Routing (`is_transparent_only` in the CLI): a seedless wallet with Sapling
keys takes the imported-account path; one with only transparent keys takes
`transparent_recovery`, because ZIP-316 gives it no UFVK to anchor an
account to.
`transparent_recovery`, because the existing ZIP-316 Revision 0 account format gives it no
UFVK to anchor an account to.

Spending imported Sapling does **not** need an upstream change: PCZT is
account-id driven and `Signer::sign_sapling` takes a raw `ask`. Only the
Expand All @@ -180,6 +180,18 @@ or `ps` (T-S6). Wired in `crates/zeck-cli/src/main.rs`; covered by
`crates/zeck-cli/tests/wallet_file_cli.rs`, which runs the real binary
against the golden fixtures.

### NU7 qualification

The coordinated NU7 SDK requires Rust 1.89. Keep `RUSTFLAGS=''` and
`CARGO_INCREMENTAL=0` consistent across Cargo invocations. The ordinary
regtest schedule remains pre-NU7; `tests/regtest/zebrad-nu7*.toml` use
independent profiles and state. `nu7_readiness.rs` includes an actual old-SDK
SQLite migration fixture and two ignored live boundary tests. The fast chain
and empty fixtures do not qualify funded supported sweeps or imported Sapling
PCZT. See `docs/qualification/nu7-supported-recovery.md` for the release gate.
Never restore removed Sprout scan, spend, P2P or journal machinery when porting
historical tests or documentation.

### Test seed (BIP-39 test vector, no real funds)
`abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon art`

Expand Down
Loading
Loading