Repository navigation
Conversation
Collaborator
Author
|
it seems more logical to have the default click be the action that the user most wants to execute for me, i usually want the normal fetch with default settings. so an extra ctrl or extra ok click seems like extra work compared to other git clients Which do you most often use? the shortcuts or the ctrl + click? or do you always go through the options menu? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Run Fetch / Pull / Push with one click, with optional saved defaults
simplify-fetch-pull-and-push-buttons.webm
Motivation
Most people don't change the options for fetch, pull, push very often. then set them once, then leave them be.
Currently the app always requires 2 clicks to fetch, pull, push. this change reduces that to 1 click, while also allowing the settings to be modified or one off runs with different settings.
What changed
Toolbar
Options panel
Behaviour changes
Implementation notes
Popuphas new virtual methods:HasDefaultOptions,SaveOptionsAsDefault()andResetDefaultOptions(). They are implemented byFetch,PullandPush.RepositoryUIStateshas three new fields:DealWithLocalChangesOnPull,SetTrackingOnPushandNoVerifyOnPush. The existingCheckSubmodulesOnPushis now actually used.Repository.RunPopupInBackgroundAsyncruns a popup'sSure()without showing the popup. It exposes theIsFetching/IsPulling/IsPushingandIs*Succeededstate that the toolbar binds to.Icons.ResetDefaultsicon.en_USonly:Text.Popup.SaveAsDefault,Text.Popup.ResetDefaults,Text.Repository.ShowOptions.