Add --cert and --key flags to step certificate inspect for mTLS - #1707
Open
DarpanAdhikari wants to merge 1 commit into
Open
DarpanAdhikari wants to merge 1 commit into
DarpanAdhikari wants to merge 1 commit into
Conversation
Allow step certificate inspect to present a client certificate and key when connecting to a remote server, enabling inspection of certificates served by mTLS-protected endpoints. The --cert and --key flags must be provided together. Fixes smallstep#65
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name of feature:
--cert/<--key> flags forstep certificate inspectto present a TLS client certificate when inspecting a remote server.Pain or issue this feature alleviates:
Closes #65 — when debugging mTLS-protected environments it was impossible to inspect a server's certificate remotely because the server rejected connections that did not present a valid client certificate.
Why is this important to the project (if not answered above):
step certificate inspectis the primary troubleshooting command for TLS; supporting mTLS peers makes it useful for inspecting certificates inside (or in front of) mTLS-enforced networks.Is there documentation on how to use this feature? If so, where?
Yes — usage text plus an EXAMPLES section on the
inspectcommand incommand/certificate/inspect.go:In what environments or workflows is this feature supported?
Any remote connection made by
inspect(https/tls/tcp/smtps/ldaps) when a client certificate pair is provided.--certand--keymust be used together.In what environments or workflows is this feature explicitly NOT supported (if any)?
Local (non-URL) certificate/CSR inspection, where no TLS connection is made. Consistent with existing remote-only flags like
--rootsand--servername.Supporting links/other PRs/issues:
Fixes #65