Repository navigation
[OMEGA-490] Out of token budget notification fix - #413
Merged
Merged
Conversation
…expression for harness notices, fix out of token budget notifying mechanism
blackhammer116
approved these changes
Oct 27, 2026
Collaborator
|
Tested: PR #413 at c2b127d, image built from that commit ( What I checked
NoteOn builds with the filter, minimax-m3 sometimes leaves a question unanswered and keeps sending "No new input to respond to." instead, which the filter drops. 3 of 10 questions went unanswered on this PR and 3 of 5 on v0.1.20, while v0.1.22 without the filter answered 7 of 7. The cause is not established, and the behavior is the same as in v0.1.20 Verdict: PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
notify, has been implemented in the channels - same assend, but without the antispam filter and without updatinglastsend. It serves only for harness notices, not for LLM answers.The main reason for implementing a separate expression for harness notices is that in a previous Omega version, we discovered an issue where a notice was sent only once because the antispam filter blocked repeated messages.
For instance, a user sends a request, then an LLM returns a response with
incomplete_reason=max_output_tokens, and the harness sends a notice via thesendexpression.If the user sends another request and an LLM returns a response with
incomplete_reason=max_output_tokensagain, the notice is blocked by the antispam filter, and the harness doesn't send anything. So that notice could only be sent once until the LLM returned a complete response.During an internal team discussion, we came to the conclusion that this filter was no longer relevant. So we decided to remove it, and this automatically solved the issue described above in #383.
But during QA, we found that small models were still spamming without any new user input, so the antispam filter is still necessary in Omega. And that's the reason for restoring it.
But in that case, send won't work for repeated notices because the antispam filter will discard them if the previous message was also a notice. So implementing a separate expression for harness notices was necessary, and that's exactly what has been done in this PR.
The previous logic for managing incomplete LLM responses, suggested by @TossSky, still remains in the providers. But notice sending has been moved to the main loop. Now each LLM response is checked for
LLM_OUTPUT_LIMIT_MARKER, and if the marker is found, the notice is sent vianotify, whilesendsends nothing.How Has This Been Tested?
Live ran + mock/unit - all passed/green.
Checklist