Skip to content

fix(browser): keep new markers out of find and time out a hung name claim - #8288

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/browser-find-new-markers
Sep 25, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/browser-find-new-markers

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up to feat(browser): sharper computer use for the desktop browser agent #8283, whose last commit did not land with the merge
  • browser_find collects its outline without new markers, so a search for "new" (or "New issue") no longer matches every recently added element, and a find no longer consumes the markers the next snapshot should show
  • A snapshot element counts as shown only once its line is actually emitted
  • The download name claim (the empty O_EXCL placeholder) runs inside the 5 s allocation timeout, so a hung filesystem stops the download instead of leaving it paused with its name reserved; a placeholder written after the timeout is removed
  • After a successful move the download record no longer points at the finished file as a placeholder
  • An already-aborted click sends no input at all, including the pointer move

Type of Change

  • Bug fix

Testing

  • 1,912 desktop tests pass; the 7 new or updated tests fail against staging's sources and pass with this change
  • Desktop type-check, lint, block registry, check:audits, and docs manifest pass
  • Tool catalog regenerated from mothership staging is unchanged, so no mothership counterpart is needed

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…laim

- browser_find collects its outline with markNew off, so a search never
  matches the `new` token and never consumes markers the next snapshot owes.
- An element counts as shown only once its line is emitted.
- The placeholder claim runs inside the allocation timeout, so a hung
  filesystem stops the download instead of leaving it paused with its name
  reserved; a late placeholder is removed when the claim settles.
- A successful move drops the placeholder pointer, and an already-aborted
  click sends no input at all, not even the pointer move.
@vercel

vercel Bot commented Sep 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 25, 2026 2:25am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adjusts browser automation snapshot capture and download handling.

The PR appears safe to merge; no actionable issue was identified.

Summary

This PR keeps new markers out of browser-find reads, puts download name claims within the allocation timeout, clears the placeholder reference after a successful move, and prevents input from an already-aborted click.

Reviews (1) · Last reviewed commit: "fix(browser): keep new markers out of fi..."

@waleedlatif1
waleedlatif1 merged commit 45e20cf into staging Sep 25, 2026
28 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/browser-find-new-markers branch September 25, 2026 02:29

This branch was previously deployed

1 inactive deployment
Preview — cf28177e Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant