Skip to content

fix(search): use shared inline tool activity - #8233

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/search-tool-activity
Sep 24, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/search-tool-activity

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Use the shared inline activity stream for search and document reads so natural-language labels update in place.

  • Keep source matches in expandable history, remove raw query text, and preserve the final cited-source panel.

  • Reuse existing tool-call spacing, icons, and styling; avoid empty disclosures for unusable saved results and misleading empty states after partial retrieval.

  • Label each result region by its natural-language activity step for screen-reader navigation.

Type of Change

  • Bug fix

Testing

  • Verified running, next-call, completed, and expanded states using production components with sample data.
  • 271 activity tests, type-check, lint, all 49 repository audits, block-registry validation, and generated-file checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 24, 2026 4:27pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 14 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no outstanding findings or actionable new issues were identified.

Summary

The PR moves search and document reads into the shared inline activity stream. Search matches remain in expandable history, raw queries are omitted from the activity display, and result regions receive step-specific accessible labels.

Reviews (2) · Last reviewed commit: "fix(search): clarify activity result sta..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 15 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit ad66fdf into staging Sep 24, 2026
35 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-tool-activity branch September 24, 2026 16:58

This branch was previously deployed

1 inactive deployment
Preview — d0f89485 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant