Skip to content

Port Claude workflow and skill updates from machine.py - #535

Merged
ddaspit merged 2 commits into
masterfrom
ddaspit/Port-Claude-Code-updates
Oct 6, 2026
Merged

ddaspit merged 2 commits into
masterfrom
ddaspit/Port-Claude-Code-updates

Conversation

@ddaspit

@ddaspit ddaspit commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Quick summary

This adds the Claude Code workflows and skill updates from machine.py. A porting issue now starts a port that opens its own PR. No library code changes.

Where to look

  • .github/workflows/claude.yml builds sentencepiece4c and restores like ci.yml, and clones machine.py to ../machine.py for the port-pr skill. It has not run yet.
  • .github/workflows/claude.yml also prints the tool calls that were denied. The jq filter is the same as in machine.py, but it has not run there or here yet.
  • .github/workflows/create-porting-issue.yml now skips PRs with the no porting label.
  • .claude/skills/port-pr/SKILL.md is machine.py's skill reversed, porting Python to C#.
  • .claude/skills/pr-review/SKILL.md follows up on earlier findings, numbers them, and uses the Reviewable keywords.

The Claude Code Review check on this PR passed without reviewing. The action skips a workflow that does not match the default branch, so reviews start after this is merged.

Validation

  • ./local_check.sh --agent-strict -- passed, 1083 tests passed and 3 skipped. The hygiene scan found no in-scope files.
  • git diff --check origin/master...HEAD -- clean
  • Parsed the workflow files with PyYAML. They parsed.
  • I did not test the jq filter, because jq is not installed here.

Issue / porting context

Ports sillsdev/machine.py#377, sillsdev/machine.py#384, sillsdev/machine.py#389, sillsdev/machine.py#391, sillsdev/machine.py#392, sillsdev/machine.py#393, sillsdev/machine.py#394 and sillsdev/machine.py#396.

🤖 Generated with Claude Code


This change is Reviewable

@ddaspit ddaspit added the no porting No porting issue is created in the other repository when this PR is merged. label Oct 2, 2026
@codecov-commenter

codecov-commenter commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.35%. Comparing base (ddc468c) to head (38afbcf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   74.35%   74.35%           
=======================================
  Files         456      456           
  Lines       38283    38283           
  Branches     5245     5245           
=======================================
  Hits        28467    28467           
  Misses       8666     8666           
  Partials     1150     1150           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

ddaspit and others added 2 commits October 6, 2026 11:50
This adds the Claude Code workflows from machine.py. The @claude workflow can
now open PRs from issues, and a porting issue starts a port with the new
port-pr skill. The code review runs on every push and follows up on its
earlier findings instead of posting them again.

A merged PR now gets a porting issue unless it has the no porting label.

Ports sillsdev/machine.py#377, #384, #389, #391, #392, #394 and #393.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The action hides Claude's output, so the log only gave a count of denied tool
calls. A new step prints each denied call's tool and command. Claude is also
told that allowed commands match by prefix, so it runs dotnet and
./local_check.sh from the repository root without cd or a wrapper. tail and
head are allowed so it can trim test output.

Ports sillsdev/machine.py#396.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no porting No porting issue is created in the other repository when this PR is merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants