Repository navigation
Quiet the Claude review and make local_check fail on any step - #409
Merged
Merged
Conversation
The review no longer comments on bugs the port shares with the C# code. It names them in one upstream line in the summary instead. A rebase that leaves the PR's changes as they were no longer starts a new review round. local_check.sh returned only pytest's exit code, so a pyright failure could be reported as a pass. It now runs every step and ends with a PASSED or FAILED line that the agents quote. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 398 398
Lines 25267 25267
=======================================
Hits 23293 23293
Misses 1974 1974 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Enkidu93
approved these changes
Oct 20, 2026
Enkidu93
left a comment
Collaborator
There was a problem hiding this comment.
@Enkidu93 reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
ddaspit
added a commit
to sillsdev/machine
that referenced
this pull request
Oct 20, 2026
Ports the rest of sillsdev/machine.py#409 for #544. The review skips a push whose diff matches the last reviewed commit, cites CI through gh pr checks, and posts a one-line summary when a round has nothing new. Agents report the local_check last line rather than a test count. The upstream-defect rule is not ported: here the C# code is the reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ddaspit
added a commit
to sillsdev/machine
that referenced
this pull request
Oct 20, 2026
This ports the rest of sillsdev/machine.py#409 for #544. The review now skips a push when the diff matches the last reviewed commit. It cites CI results from gh pr checks, and it posts a one-line summary when a round has no new findings. Agents now report the last line of local_check.sh instead of a test count. I did not port the rule for upstream defects. In machine.py, it skips defects that are shared with the C# code. In this repo, the C# code is the reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ddaspit
pushed a commit
to sillsdev/machine
that referenced
this pull request
Oct 20, 2026
…from machine.py (#545) Ports sillsdev/machine.py#409. Closes #544. local_check.sh now runs every step and fails when any step fails. Its last line names the failed steps. The Claude review skips a push when the diff matches the last reviewed commit, cites CI results from gh pr checks, and treats a defect shared with machine.py as an upstream defect. Agents report the last line of local_check.sh instead of a test count. Merged PRs with the Hermit Crab label no longer create a porting issue. Co-authored-by: Eli C. Lowry <83078660+Enkidu93@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick summary
The review now lists bugs shared with the C# code in its summary and skips rebases that change nothing.
local_check.shnow fails when any step fails, not only pytest. Nothing inmachine/ortests/changes.Where to look
changesjob compares the PR's diff at the lastReviewed atcommit with the diff at the head. I ran it on the review rounds from Convert USFM versification before updating from rows #390, Limit zip file entries to 100MB by default #406, and Add try_get_chapters to scripture parsing #407. It skips the three rebases and still reviews the real change on Limit zip file entries to 100MB by default #406 (89685bd to bdce2ab).local_check.shruns every step and ends withlocal_check: PASSEDorlocal_check: FAILED (<steps>). The pyright errors that failed CI on Limit zip file entries to 100MB by default #406 reproduce locally at 6a53b79, so the earlier "868 passed" hid a pyright failure.pr-reviewskill no longer posts line comments for upstream defects. A round with nothing new posts a one-line summary.Deliberately not included
The two Reviewable mentions on #406 and #407 that got no response are not fixed. The action logged "No trigger was met for @claude" even though the review began with @claude. I could not find the cause. A new step prints the review body when this happens, so the next miss should show why. A top-level PR comment works in the meantime.
Validation
./local_check.sh --agent-strict--local_check: PASSED(894 passed, 3 skipped)./local_check.shwith a stubpoetrywhose pyright fails --local_check: FAILED (pyright), exit 1git diff --check <merge-base>...HEAD-- cleanchangesjob.Decisions, and why
The rebase check compares with the last reviewed commit rather than the previous push. The review's concurrency group cancels an in-progress round, so a quick rebase after a fix could otherwise cancel the review of the fix and then skip.
The review does not run
local_check.shbecause black and isort rewrite files. It citesgh pr checksinstead, so its summaries stop listing local_check as unverified.🤖 Generated with Claude Code
This change is