Skip to content

Quiet the Claude review and make local_check fail on any step - #409

Merged
ddaspit merged 1 commit into
mainfrom
ddaspit/Claude-Code-review-fixes
Oct 20, 2026
Merged

ddaspit merged 1 commit into
mainfrom
ddaspit/Claude-Code-review-fixes

Conversation

@ddaspit

@ddaspit ddaspit commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Quick summary

The review now lists bugs shared with the C# code in its summary and skips rebases that change nothing. local_check.sh now fails when any step fails, not only pytest. Nothing in machine/ or tests/ changes.

Where to look

Deliberately not included

The two Reviewable mentions on #406 and #407 that got no response are not fixed. The action logged "No trigger was met for @claude" even though the review began with @claude. I could not find the cause. A new step prints the review body when this happens, so the next miss should show why. A top-level PR comment works in the meantime.

Validation

  • ./local_check.sh --agent-strict -- local_check: PASSED (894 passed, 3 skipped)
  • ./local_check.sh with a stub poetry whose pyright fails -- local_check: FAILED (pyright), exit 1
  • git diff --check <merge-base>...HEAD -- clean
  • The workflow changes have not run in Actions yet. This PR's own review runs the new changes job.

Decisions, and why

The rebase check compares with the last reviewed commit rather than the previous push. The review's concurrency group cancels an in-progress round, so a quick rebase after a fix could otherwise cancel the review of the fix and then skip.

The review does not run local_check.sh because black and isort rewrite files. It cites gh pr checks instead, so its summaries stop listing local_check as unverified.

🤖 Generated with Claude Code


This change is Reviewable

The review no longer comments on bugs the port shares with the C# code. It
names them in one upstream line in the summary instead. A rebase that leaves
the PR's changes as they were no longer starts a new review round.

local_check.sh returned only pytest's exit code, so a pyright failure could be
reported as a pass. It now runs every step and ends with a PASSED or FAILED
line that the agents quote.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

codecov-commenter commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.18%. Comparing base (0e78bb8) to head (79bc02d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         398      398           
  Lines       25267    25267           
=======================================
  Hits        23293    23293           
  Misses       1974     1974           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Enkidu93 reviewed 5 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

@ddaspit
ddaspit merged commit 67d949f into main Oct 20, 2026
22 checks passed
@ddaspit
ddaspit deleted the ddaspit/Claude-Code-review-fixes branch October 20, 2026 14:36
ddaspit added a commit to sillsdev/machine that referenced this pull request Oct 20, 2026
Ports the rest of sillsdev/machine.py#409 for #544. The review skips a push
whose diff matches the last reviewed commit, cites CI through gh pr checks, and
posts a one-line summary when a round has nothing new. Agents report the
local_check last line rather than a test count.

The upstream-defect rule is not ported: here the C# code is the reference.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ddaspit added a commit to sillsdev/machine that referenced this pull request Oct 20, 2026
This ports the rest of sillsdev/machine.py#409 for #544. The review now skips a
push when the diff matches the last reviewed commit. It cites CI results from
gh pr checks, and it posts a one-line summary when a round has no new findings.
Agents now report the last line of local_check.sh instead of a test count.

I did not port the rule for upstream defects. In machine.py, it skips defects
that are shared with the C# code. In this repo, the C# code is the reference.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ddaspit pushed a commit to sillsdev/machine that referenced this pull request Oct 20, 2026
…from machine.py (#545)

Ports sillsdev/machine.py#409. Closes #544.

local_check.sh now runs every step and fails when any step fails. Its last line
names the failed steps. The Claude review skips a push when the diff matches
the last reviewed commit, cites CI results from gh pr checks, and treats a
defect shared with machine.py as an upstream defect. Agents report the last
line of local_check.sh instead of a test count. Merged PRs with the Hermit Crab
label no longer create a porting issue.

Co-authored-by: Eli C. Lowry <83078660+Enkidu93@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants