Skip to content

feat: [2/2] seed source images when selecting generation models - #200

Merged
dazzatronus merged 1 commit into
mainfrom
feat/generation-source-image
Sep 24, 2026
Merged

dazzatronus merged 1 commit into
mainfrom
feat/generation-source-image

Conversation

@dazzatronus

@dazzatronus dazzatronus commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Selecting an image-editing model should use the image already on the clip. Seed an empty imageUrls list from the raw clip source in the same update as model selection. Preserve existing references and merge placeholders.

Activation: requires the existing generation-settings hook, an image clip with a source, and a model declaring imageUrls. Other integrations keep their current inputs. No new configuration or public exports.

Verify: npm run verify:ci passes (2,141 tests, lint, types, build and package contracts). Regression checks cover empty/existing references, raw placeholders, absent sources, video clips and hook/schema gating.

Order PR Change Why separate
1 #199 Clickable status annotations Host actions and toolbar presentation
2 #200 current Seed source images Model selection and stored inputs
flowchart TD
    A[Choose a generation model] --> B{Settings hook enabled and model accepts source images?}
    B -->|No| C[Keep current inputs]
    B -->|Yes| D{Image source present and references empty?}
    D -->|Yes| E[Use clip source as Image 1]
    D -->|No| C
    C --> F{Status hook registered?}
    E --> F
    F -->|No| G[Use normal generation controls]
    F -->|Yes| H[Host supplies status for current settings]
    H --> I{Error status?}
    I -->|Yes| J[Block Generate and Enter]
    I -->|No| K[Apply normal generation checks]
    H --> L{Host supplied an action?}
    L -->|No| M[Show status as text]
    L -->|Yes| N[Show status button beside Generate]
    N --> O[Click or use Enter or Space]
    O --> P[Open the host view]
Loading

Rules: model selection, status activation, generation guard.

@dazzatronus
dazzatronus marked this pull request as ready for review September 24, 2026 12:07
@dazzatronus
dazzatronus added this pull request to stack #201 September 24, 2026 12:15
Base automatically changed from feat/generation-status-action to main September 24, 2026 12:15
@dazzatronus
dazzatronus force-pushed the feat/generation-source-image branch from 624bdeb to 7eaa711 Compare September 24, 2026 12:16
@dazzatronus
dazzatronus merged commit 26f9670 into main Sep 24, 2026
1 check passed
@dazzatronus
dazzatronus deleted the feat/generation-source-image branch September 24, 2026 12:22
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant