feat: [2/2] seed source images when selecting generation models - #200
Merged
Merged
Conversation
dazzatronus
marked this pull request as ready for review
September 24, 2026 12:07
dazzatronus
added this pull request to stack #201
September 24, 2026 12:15
dazzatronus
force-pushed
the
feat/generation-source-image
branch
from
September 24, 2026 12:16
624bdeb to
7eaa711
Compare
|
🎉 This PR is included in version 2.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting an image-editing model should use the image already on the clip. Seed an empty
imageUrlslist from the raw clip source in the same update as model selection. Preserve existing references and merge placeholders.Activation: requires the existing generation-settings hook, an image clip with a source, and a model declaring
imageUrls. Other integrations keep their current inputs. No new configuration or public exports.Verify:
npm run verify:cipasses (2,141 tests, lint, types, build and package contracts). Regression checks cover empty/existing references, raw placeholders, absent sources, video clips and hook/schema gating.flowchart TD A[Choose a generation model] --> B{Settings hook enabled and model accepts source images?} B -->|No| C[Keep current inputs] B -->|Yes| D{Image source present and references empty?} D -->|Yes| E[Use clip source as Image 1] D -->|No| C C --> F{Status hook registered?} E --> F F -->|No| G[Use normal generation controls] F -->|Yes| H[Host supplies status for current settings] H --> I{Error status?} I -->|Yes| J[Block Generate and Enter] I -->|No| K[Apply normal generation checks] H --> L{Host supplied an action?} L -->|No| M[Show status as text] L -->|Yes| N[Show status button beside Generate] N --> O[Click or use Enter or Space] O --> P[Open the host view]Rules: model selection, status activation, generation guard.