Repository navigation
fix: sidebar index pages, phone-width previews and tables - #32
Merged
Merged
Conversation
…sting it twice A folder with an index.md showed its title twice: as the section label and as a page right under it. The label now links to the index page (highlighted when current) and the page isn't repeated; collapsible sections keep a separate chevron toggle. aria-expanded is written as "true"/"false", since Blazor dropped the attribute when false.
A markdown table wider than the viewport widened the whole page on phones. Rendered tables are wrapped in .shelldocs-table, which scrolls horizontally.
Pagination, toolbars and OTP rows are wider than a phone and spilled past the preview frame. razor:preview scroll / Layout="scroll" lets such an example scroll inside the frame (opt-in, since a scroll box clips popovers). On phones the frame's side padding drops to 0.75rem, and centring uses safe center so a too-wide example starts at the left edge instead of losing both sides.
Cuts the Unreleased section as 0.1.11-alpha and records the release in the ROADMAP's hardening list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes found while moving the ShellUI docs to ShellDocs 0.1.10 and ShellUI 0.3.2.
Fixed
index.mdtwice: as the section label and again as a page with the same title ("Components" / "Components", "Form" / "Form Components"). The label now links to the index page and is highlighted when you're on it, and the page isn't repeated. Collapsible sections keep a separate chevron toggle.aria-expanded. Blazor drops afalseboolean attribute, so the toggle now writes"true"/"false"..shelldocs-tablebox that scrolls horizontally.Added
scrollpreview layout.razor:preview scroll, orLayout="scroll"on<DemoPreview>/<ComponentPreview>, lets an example wider than the frame (pagination, toolbars, OTP inputs) scroll inside it instead of spilling past it. It's opt-in, because a scroll box clips popovers.Changed
safe center, so an example that's still too wide starts at the left edge instead of losing both sides.Testing
dotnet build: 0 warnings.dotnet test: 306 passing, including the newSidebarIndexPageTests, a table-wrapping test and scroll-layout cases.