Repository navigation
fix(notifications): use a local device profile without wallet login - #12742
Draft
0xApotheosis wants to merge 1 commit into
Draft
0xApotheosis wants to merge 1 commit into
0xApotheosis wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Public wallet addresses could select an existing notification profile. Uses a persistent device key and silently renewed in-memory sessions instead.
Issue (if applicable)
N/A.
Risk
High: profile/notification registration. Requires microservices #68/#69 and mobile #165/#166. Clearing site data creates a new profile.
Testing
Engineering
Enable WebServices against the paired QA backend. Two browser profiles using the same wallet must get separate IDs; reload must preserve each ID. Expire a session: expect one renewal. Clearing site data must not restore old history. Mocked checks passed; integration/device QA remains outstanding.
Operations
Open the QA app in two browser profiles and connect the test wallet: no login signature should appear. Reload each. In the paired native build, allow notifications and keep the app open: registration should be silent and an ordinary test notification should arrive. Engineering confirms profile isolation and push verification.
Screenshots (if applicable)
N/A.