Skip to content

fix(notifications): use a local device profile without wallet login - #12742

Draft
0xApotheosis wants to merge 1 commit into
developfrom
security/mic01-client
Draft

0xApotheosis wants to merge 1 commit into
developfrom
security/mic01-client

Conversation

@0xApotheosis

@0xApotheosis 0xApotheosis commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Description

Public wallet addresses could select an existing notification profile. Uses a persistent device key and silently renewed in-memory sessions instead.

Issue (if applicable)

N/A.

Risk

High: profile/notification registration. Requires microservices #68/#69 and mobile #165/#166. Clearing site data creates a new profile.

Testing

Engineering

Enable WebServices against the paired QA backend. Two browser profiles using the same wallet must get separate IDs; reload must preserve each ID. Expire a session: expect one renewal. Clearing site data must not restore old history. Mocked checks passed; integration/device QA remains outstanding.

Operations

Open the QA app in two browser profiles and connect the test wallet: no login signature should appear. Reload each. In the paired native build, allow notifications and keep the app open: registration should be silent and an ordinary test notification should arrive. Engineering confirms profile isolation and push verification.

Screenshots (if applicable)

N/A.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant