Repository navigation
Release/1.33.7 - #2239
Merged
Merged
Release/1.33.7#2239
Conversation
Voice and audio messages never played on 1.33.6; the play button spun indefinitely. AudioMediaService built its connection result from super.onConnect(), which in media3 1.11.0 returns a placeholder with no commands, so the in-app MediaController's setMediaItem, prepare and play were all dropped. Grant the default session and player commands explicitly, as 1.10.0's onConnect() did. Also log when the controller lacks playback commands, leave the loading state on a player error, and add an instrumented test that the in-app controller is granted them.
Fix voice/audio playback broken by media3 1.11.0, bump to 1.33.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.