[devnacho]

Why

#169 made a quoted-text check (verify …, wait until the text … is shown) treat an unreadable page as "not yet" and keep polling. But if the text was still unreadable when the step timed out, the step was recorded as unsupported, so the test ended could_not_run and --retries never repeated it.

This is the part of #165 (thanks @bagrat) that #169 didn't already cover.

What changes

• Text still unreadable at the deadline fails the step with text_unreadable ("The page text could not be read."), the same way absent text fails with text_check.
• Nothing else changes: the polling from Settle click and type steps after a page change #169 stays as it is.

Testing

• New flow-runner/assertion-text.test.ts, using the fake-page harness from fix(core): keep polling text checks while the next page loads #165: a page whose text never becomes readable. The step polls to the deadline and records failed with text_unreadable. It fails on main (could_not_run) and passes with this change.
• npx tsc --noEmit -p packages/core and eslint are clean, npx vitest run packages/core passes (729), and flow-runner.steps.integration.test.ts passes with SEDUM_BROWSER_INTEGRATION=1 (26).
• The CodeScene pre-commit safeguard passes.

    

[coldtea-pr-lens]

Architecture

Data flow

Review

✨ Nothing flagged · reviewed e228a86

Tip

The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change

🪧 More tips

• Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
• Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
• Click the link under each diagram to open it on a canvas you can zoom, pan and step through
• Open a diagram on the canvas, then press W or click play to walk through the change one step at a time
• The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
• Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs as before
• Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
• Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
• After a push, tick Redraw to draw the latest commit
• Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion
• Set github.description: false in .github/pr-lens.yml to stop PR Lens adding buttons to your PR descriptions

_{Thanks for using PR Lens! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out on X, Bluesky, Mastodon, Reddit or LinkedIn}