feat: Update to @seamapi/types@1.1086.0 - #1034
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a3cb064 to
ea605e0
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3cb064eb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "resolved": "https://registry.npmjs.org/@seamapi/types/-/types-1.1081.0.tgz", | ||
| "integrity": "sha512-bFh94NyhpR1nukmihSxLR68TAgYGvbk+JeBnOWHtmNkP9FABSeuplw6cXBjB7S+xiVoazUCnclgrJ9lVnijCvw==", | ||
| "version": "1.1086.0", | ||
| "resolved": "https://npm.pkg.github.com/download/@seamapi/types/1.1086.0/a722414fe46dfb80325ead9b6a491b902dc8a310", |
There was a problem hiding this comment.
The lockfile now pins @seamapi/types to GitHub Packages, which requires GitHub authentication even for public npm packages. Fresh contributor installs and the check jobs—whose setup action runs npm ci with the npmjs registry and no GitHub Packages token—will fail while fetching this absolute URL. Pin the npmjs tarball URL instead, as was done for the previous version.
Useful? React with 👍 / 👎.
| /** | ||
| * Response format. `json` returns the media object. `redirect` responds with a `302` redirect to the media's download URL, so you can use this endpoint directly as the source of an image or video. | ||
| */ | ||
| format?: 'json' | 'redirect' | undefined |
There was a problem hiding this comment.
When a caller supplies format: 'redirect', the Axios fetch adapter follows the 302 and returns the downloaded image or video payload, but this request remains typed as MediaGetResponse and SeamHttpRequest.execute() attempts to read a media property from that payload. Consequently, awaiting this valid typed request throws SeamHttpInvalidResponseError rather than producing a useful result. Either exclude redirect from this SDK method or add response handling that does not perform the normal JSON-key extraction.
Useful? React with 👍 / 👎.
This branch was successfully deployed
1 participant
Summary
Bumps
@seamapi/typesto1.1086.0, which publishes:/media/get— retrieve a piece of media (e.g. a camera event's video clip or thumbnail) with a short-lived download URL/cameras/live_views/create,/cameras/live_views/offer,/cameras/live_views/stop— WebRTC camera live view endpointsRan
npm run generateto regenerate the SDK against the new types, which addsSeamHttpMediaandSeamHttpCamerasLiveViewsroute classes plus their resource types, and wires them intoSeamHttpEndpoints.Test plan
npm test— 177 tests passednpm run lint— eslint + prettier check passnpm run typecheck— passes with no errors🤖 Generated with Claude Code