feat: Add media.get, cameras.live_views and can_stream_live_video - #331
Conversation
Bump @seamapi/types to 1.1092.0 and @seamapi/blueprint to ^1.12.0 and regenerate. The Media model shares its name with the Media API class, so return types that would be shadowed inside Seam.Api are now fully qualified. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d135b9d53d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "resolved": "https://registry.npmjs.org/@seamapi/blueprint/-/blueprint-1.9.1.tgz", | ||
| "integrity": "sha512-A9H3dZE9f+ZEEnOAlMl5jSlL5F/RIKkjOF8NDFbnuahAiu/trDz/RzHOGhbQd6sd0RErIyx3eG1p4HCOJDKDCA==", | ||
| "version": "1.12.0", | ||
| "resolved": "https://npm.pkg.github.com/download/@seamapi/blueprint/1.12.0/e72f21582831d9be77804b63aafcc9cf48b7e2cc", |
There was a problem hiding this comment.
On fresh CI runners, both the lint/typecheck setup and the Generate workflow install dependencies without a GitHub Packages token (.github/actions/setup-node/action.yml runs npm ci, while generate.yml runs npm install), but these locked tarball URLs require authentication; only the devcontainer config supplies GH_TOKEN. Consequently dependency installation will fail before any checks or generation run. Regenerate the lockfile against the public npm registry or configure GitHub Packages authentication in every workflow that installs dependencies.
Useful? React with 👍 / 👎.
| [EnumMember(Value = "redirect")] | ||
| Redirect = 2, |
There was a problem hiding this comment.
When callers select FormatEnum.Redirect, the endpoint returns a 302/media body rather than the JSON GetResponse that Get and GetAsync always deserialize and unwrap. RestSharp either follows the redirect to non-JSON content or leaves a response with no GetResponse, so EnsureData fails instead of providing the advertised redirect result. This option needs a response path that returns the redirect/download response, or it should not be exposed by these model-returning methods.
Useful? React with 👍 / 👎.
2 participants
Bumps
@seamapi/types1.1047.0 -> 1.1092.0 and@seamapi/blueprintto ^1.12.0, then regenerates. Dependabot bumps here have been closed since July, so this also picks up every API change since 1.1047.0.New in the SDK:
seam.Media.Get,seam.LiveViewsCameras.{Create,Offer,Stop}, theMedia/CameraLiveViewSession/CameraLiveViewAnswermodels, andCanStreamLiveVideoon devices.Codegen fix: inside
namespace Seam.Api, theMediaAPI class shadows theSeam.Model.Mediamodel, soMedia.Getwould have returned (and tried to deserialize into) the API class.codegen/lib/build-model.tsnow fully qualifies a return model whose name matches its API class. No other API is affected.No .NET toolchain locally: csharpier formatting is left to the Generate workflow, and compilation/tests to Check.
🤖 Generated with Claude Code