Repository navigation
feat(models)!: KV admission only with concurrency_limit auto - #286
Merged
Merged
Conversation
KV admission and `concurrency_limit: auto` are now on together or off together. Since #277 an SGLang engine sieval run launched admitted requests by a KV TokenBudget whenever its root set no concurrency_limit; `auto` added the engine's load on top (#278), and #284 deferred either to the first request for a root bound before its engine was up. A root with no concurrency_limit is back on the path it had before #277: no shared root limiter, no token budget, and the launch reads no /get_server_info, so it prints no `KV:` line and its request records carry no `kv_tokens`. A number keeps its fixed cap. `auto` is unchanged: an AdaptiveTokenBudget from the pool the launch read, or a PendingTokenBudget read at the first request when the engine is not up yet, and the same refusals when no pool is reported. No identity or plan field depended on the default: the KV facts are not in the deployment fingerprint, and admission was throughput only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`sets_auto_concurrency` copied the "top level wins over args" rule from `_connection_options`; if the two drifted, the launch would skip the KV pool read while the session still saw `auto`. Both now call one helper, and a test pins the precedence. Docs, CHANGELOG and comments trimmed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Summary
concurrency_limit: autoare now on together or off together (maintainer decision). Since feat(models): admit requests to a launched engine by the KV they may hold #277 an SGLang enginesieval runlaunches admitted requests by a KVTokenBudgetwhenever its root set noconcurrency_limit.concurrency_limitis back on the pre-feat(models): admit requests to a launched engine by the KV they may hold #277 path: no root limiter, no token budget, and_launchreturnsdeployer.build_deployment(...)without reading/get_server_info. So noKV:launch line and nokv_tokensin request records. A number keeps its fixed cap.autois unchanged: anAdaptiveTokenBudgetfrom the pool the launch read, or aPendingTokenBudgetread at the first request when the engine is not up yet (fix(models): concurrency_limit auto is accepted before its engine is up #284), and the same refusals when no pool is reported. TheKV:line prints only forautoroots.deployment_fingerprint, and admission was throughput only.RESULT_SCHEMA_VERSIONand identity schema are unchanged.docs/guide/concurrency.md: the KV Admission section is now part ofconcurrency_limit: auto. CHANGELOG has an Unreleased "Changed" entry.Breaking change
A root with no
concurrency_limiton a launched SGLang engine loses the KV admission 0.15.5/0.15.6 gave it. To keep it, setconcurrency_limit: auto.Related Issues
Refs #277, #278, #284
Test Plan
Automated
ruff check && ruff format --check, plus pre-commit on the changed files)ty checkreports the same 26unresolved-importdiagnostics onorigin/mainand on this branch. All of them come from optional task extras (nltk, sympy, ...) that this venv does not have.pytest tests/unit -n 8fails the same 190 tests onorigin/mainand on this branch, and the failing set is identical (diffed). All of them need task extras that are not installed. No new failures.pytest tests/integration -n 8gives 179 passed, 19 skipped.TestAutoConcurrency.test_no_auto_gets_no_kv_admission(no limit / a number: no budget even when the engine reported its pool)test_auto_builds_the_kv_budgettest_sets_auto_concurrency_reads_both_spellingstest_no_limit_gets_no_kv_admissionandtest_a_judge_with_no_limit_started_at_a_barrier_gets_no_kv_admission(no/get_server_inforead, no reservation); the existingautorun test now also asserts that only theautoroot reads the poolChecklist
Required (all PRs)
type(scope): description)AI-Generated Code - <model> (<provider>)in module docstringcore/If: Breaking Change
🤖 Generated with Claude Code