Repository navigation
fix(kbc): bound worker shutdown and preserve recovery ownership - #601
Closed
LikiosSedo wants to merge 2 commits into
Closed
LikiosSedo wants to merge 2 commits into
LikiosSedo wants to merge 2 commits into
Conversation
LikiosSedo
force-pushed
the
feat/kb-conversation-execution
branch
from
September 14, 2026 06:39
38582d7 to
8a6f0f0
Compare
LikiosSedo
force-pushed
the
feat/kb-conversation-execution
branch
from
September 14, 2026 11:40
8a6f0f0 to
eef8430
Compare
LikiosSedo
force-pushed
the
feat/kb-conversation-execution
branch
from
September 14, 2026 11:46
eef8430 to
5387c78
Compare
Collaborator
Author
|
Superseded. Siclaw delivery has moved off this public repository; this change is continuing on the internal Siclaw repo. Closing the public PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planner and batch sessions previously replaced the persistent authoring client and shared reply/completion state. Give each internal step its own client, task and reply. SDK connection and teardown stay in the same task; confirmed teardown permits the existing batch retry, while unconfirmed teardown prevents workspace reuse, synchronization, planner fallback and finalization.
Bound the interrupt call and worker cleanup so a stalled SDK cannot hold execution indefinitely. Cleanup failure emits
worker_teardown_failed; Runtime persists and acknowledges the fatal error, then closes the relay so its existing cleanup disposes the box. It does not consume later artifacts from that worker. A late interrupt failure cannot reap a successor client. User cancellation stays cancelled. Close Claude subprocess pipes after SDK disconnect, including unread output from an aborted tool turn.The command protocol and artifact/checkpoint commit contract remain compatible. Recovery schedules and ticket-repair admission remain control-plane responsibilities. This change does not add a persistent ticket-repair queue. Two existing self-check assertions are also aligned with the current fixture line numbering and bounded-repair contract.
Validation:
npm run buildand finaltsc --noEmitpassed;npm test: 7,609 passed.test_compile_box.pyHTTP/SSE protocol smoke passed.Rollout: ship matching Runtime and KBC box images; Runtime may be upgraded first. Existing boxes retain their original image. No image publication, cluster deployment or hosted-model acceptance was performed for this revision.