Repository navigation
Conversation
Comment on lines
+203
to
+204
| " # TODO We need to associate data with banks so that assemble_detector_data\n", | ||
| " # can put it all together. But the events loaded here lack the required\n", |
Member
There was a problem hiding this comment.
Can you clarify the problem? event_id is unique across banks, so in Livedata I just concat and then binning into the concatenated empty detector just works.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft of a workflow for BIFROST that avoids map-reduce in Sciline. It is in a new notebook for now.
I hit a roadblock with merging detector data and geometry. See the TODO comment in
load_bifrost_detector_data. I'd like to know if I should proceed at all before solving this. The old mechanism solved this problem nicely and so wouldStages.How do you do this in livedata, Simon?