Skip to content

Pin synapse-api 2.6.1 (signed spike threshold); release 2.8.5 #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calvinleng-science merged 3 commits into from
Oct 27, 2026
Merged

Pin synapse-api 2.6.1 (signed spike threshold); release 2.8.5 #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
234d539
chore: pin synapse-api 2.6.1 (signed threshold_uV); release 2.8.5
calvinleng-science Oct 27, 2026
dd6d7a1
chore: re-point synapse-api submodule after its branch history was re…
calvinleng-science Oct 27, 2026
0d14b22
chore: pin synapse-api to main (2.6.1, #86 merged)
calvinleng-science Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def stamp_api_version():

setup(
name="science-synapse",
version="2.8.4",
version="2.8.5",
description="Client library and CLI for the Synapse API",
author="Science Team",
author_email="team@science.xyz",
Expand Down
2 changes: 1 addition & 1 deletion synapse-api
Open in desktop
Submodule synapse-api updated 2 files
+1 −1 VERSION
+1 −1 api/nodes/spike_detector.proto
2 changes: 1 addition & 1 deletion synapse/_api_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# Generated from synapse-api/VERSION by setup.py. Do not edit.
SYNAPSE_API_VERSION = "2.6.0"
SYNAPSE_API_VERSION = "2.6.1"
10 changes: 10 additions & 0 deletions synapse/tests/client/test_spike_detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,13 @@ def test_to_proto_template_matcher():
test_to_proto_template_matcher()
print("All tests passed!")



def test_negative_threshold_round_trips():
# threshold_uV is int32 (synapse-api 2.6.1): the sign is the crossing direction.
detector = SpikeDetector(samples_per_spike=32, config=ThresholderConfig(threshold_uV=-400))
proto = detector._to_proto().spike_detector
assert proto.thresholder.threshold_uV == -400

wire = SpikeDetectorConfig.FromString(proto.SerializeToString())
assert SpikeDetector._from_proto(wire).threshold_uV == -400
Loading