Repository navigation
fix: signed Thresholder.threshold_uV - #86
Merged
Merged
Conversation
The sign sets the crossing direction: negative fires below the threshold (extracellular spikes), positive above it. Wire-compatible with uint32 for existing non-negative values. Bumps VERSION to 2.7.0.
calvinleng-science
added a commit
that referenced
this pull request
Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
calvinleng-science
added a commit
that referenced
this pull request
Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
calvinleng-science
changed the title
calvinleng-science
changed the title
calvinleng-science
changed the title
calvinleng-science
force-pushed
the
calvin/signedness-api-issue
branch
from
October 27, 2026 02:19
05f8726 to
0b686d6
Compare
calvinleng-science
added a commit
to sciencecorp/synapse-python
that referenced
this pull request
Oct 27, 2026
Points the `synapse-api` submodule at 2.6.1 (sciencecorp/synapse-api#86), where `Thresholder.threshold_uV` becomes `int32` so a threshold can describe negative- as well as positive-going events. With the old pin the client rejects a negative threshold before sending (`ValueError: Value out of range`). - `_api_version.py` → 2.6.1, package → 2.8.5. - New test: a negative threshold round-trips through `SpikeDetector` and the wire. - 238/238 tests pass. Verified end to end against a device: a negative threshold fires on negative-going events and stays silent below the signal's trough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Thresholder.threshold_uVfromuint32toint32so a threshold can describe both positive- and negative-going events: the sign is the crossing direction. Previously only positive thresholds were expressible.Wire-compatible:
uint32andint32share the varint encoding, so existing non-negative values are unchanged. BumpsVERSIONto 2.6.1.