Repository navigation
Cli-testing migration : remove small dependencies - #2547
Closed
SylvainSenechal wants to merge 5 commits into
Closed
SylvainSenechal wants to merge 5 commits into
SylvainSenechal wants to merge 5 commits into
Conversation
…Keys helpers Issue: ZENKO-5280
Contributor
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Contributor
Author
|
Superseded by #2548 (wrong ticket number, should be ZENKO-5372). |
SylvainSenechal
commented
Oct 5, 2026
| 'storage-account-owner-role', this.parameters.KeycloakTestPassword); | ||
| break; | ||
| case EntityType.DATA_CONSUMER: | ||
| await this.prepareARWWI(this.parameters.DataConsumerUsername || 'data_consumer', |
Contributor
Author
There was a problem hiding this comment.
Imo not a good idea to have these kind of fallbacks hanging around when they are not used at all.
Would be re added if it ever was to become useful again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZENKO-5280
Moving from cli-testing directly into this codebase :
Upcoming work for cli-testing, 2 more tickets :