Repository navigation
Remove ModernCpp and ModernCppRoot naming; use IISNativeModule - #6
Merged
Merged
Conversation
Rename every ModernCpp reference to its IISNativeModule equivalent: root project IISNativeModuleRoot, targets IISNativeModuleApp/ IISNativeModuleUtils/IISNativeModuleTest, toolchain variables IISNATIVEMODULE_*, vcpkg manifest name iisnativemodule, README heading, the smoke greeting string and its test expectation, and the coverage script's test-binary path. The module DLL target keeps its existing IISNativeModule name. Closes #5 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModernCpp*reference to itsIISNativeModuleequivalent across 15 files: root projectIISNativeModuleRoot, targetsIISNativeModuleApp/IISNativeModuleUtils/IISNativeModuleTest, toolchain variablesIISNATIVEMODULE_*, vcpkg manifest nameiisnativemodule, README heading, the smoke greeting string and its test expectation, and the coverage script's test-binary path.IISNativeModulename; the other targets use suffixed names to avoid collisions with it.*_DEPENDENCIESCMake variable, and the outdated "modern C++ examples" project description).Test plan (from #5)
_buildfoldercmake --preset="windows-x86-64-debug"configures from scratchcmake --build --preset="windows-x86-64-debug" -t IISNativeModulebuilds the DLLctestpassNotes for reviewers
.gitgnore, so_build/is not actually ignored; that fix is deliberately left out of this PR as a separate follow-up.Closes #5
🤖 Generated with Claude Code