Repository navigation
Remove the smoke utility and the leftover demo application - #13
Merged
Merged
Conversation
smoke.h/.cpp and its test were the placeholder carried over from the ModernCpp template and had no relation to the IIS module. Removing them empties src/utils, so the IISNativeModuleUtils target goes with them. src/main.cpp went too: its entire body was printing the smoke greeting, so it could not survive smoke's removal, and the target it backed (IISNativeModuleApp) was linked by nothing, named nowhere in CI, and meaningless for an in-process module that IIS loads as a DLL. src/CMakeLists.txt is now a pure aggregator for core and module. The test target drops its IISNativeModuleUtils link and its explicit ../src include directory; the <core/...> includes resolve through the PUBLIC include directory IISNativeModuleCore already exports. fmt and spdlog stay declared in vcpkg.json even though nothing links them now, so they remain available for future logging work. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final cleanup of the scaffolding inherited from the ModernCpp template, leaving only the code that serves the IIS module.
smoke.h/smoke.cppandsmoke_test.cpp— placeholder code with no relation to the module. This emptiessrc/utils/, and a CMake target with zero sources is a hard error, so theIISNativeModuleUtilstarget goes with them.src/main.cppand theIISNativeModuleApptarget — see the evaluation below.src/CMakeLists.txtis now a pure aggregator forcoreandmodule.IISNativeModuleUtilslink and its explicit../srcinclude directory; the<core/...>includes resolve through the PUBLIC include directoryIISNativeModuleCorealready exports.TestCorecase instead of the deleted smoke test.Why
src/main.cppwas safe to removeIt could not have survived the smoke removal regardless — its entire body was
fmt::printing the smoke greeting. Everything else pointed the same way:IISNativeModuleApptarget it backed was linked by nothing.ctest.scripts/generate_coverage.bat, which only uses the test binary.main()has no role.Note for reviewers
fmtandspdlogare intentionally kept invcpkg.jsonand the top-levelfind_packagecalls even though no target links them any more — they stay available for future logging/formatting work. CLAUDE.md records this so they aren't later pruned as "unused".Test plan
Verified from a wiped
_build/:cmake --preset windows-x86-64-debugconfigures cleanly from scratchTestCorecases; the smoke test is gone as intended)dumpbin -exportsconfirms the DLL still exportsRegisterModuleundecorated🤖 Generated with Claude Code