Repository navigation
fix(compiler): preserve literal variable reference text - #97
Open
BichengWang wants to merge 1 commit into
Open
BichengWang wants to merge 1 commit into
BichengWang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Preserve literal
@variablestext when compiling expressions.Why
Fixes #96. For example,
@variables.x == "@variables.x"currently compiles tostate.x == "state.x", changing the comparison. Literal text can also trigger an unknown-variable warning.How
Remove the final regex replacement over serialized expressions. Reference AST nodes already resolve recursively, including inside function arguments. Add five regression cases covering parsed literals, comparisons, mixed literal/reference arguments, escaped quotes, and template text alongside real references.
Test Plan
All five new cases failed before the fix and pass afterward.
pnpm exec turbo run test --force: 24/24 tasks; compiler: 1,118 passed, 3 skipped)pnpm exec turbo run lint --forceandpnpm exec turbo run typecheck --force; lint reports 12 existing UI warnings)pnpm format:check, changed-file ESLint, and the server path traversal regression suite passChecklist