Repository navigation
chore(deps): clear the RustSec advisories failing cargo-audit and cargo-deny - #8
Open
gitfromwildan wants to merge 4 commits into
Open
gitfromwildan wants to merge 4 commits into
gitfromwildan wants to merge 4 commits into
Conversation
Semver-compatible updates that clear RustSec advisories failing cargo-audit and cargo-deny: crypto-bigint 0.7 (RUSTSEC-2026-0387), ctutils (RUSTSEC-2026-0385), quinn-proto (RUSTSEC-2026-0338, -0340, -0343, -0523, -0524), quinn-udp (RUSTSEC-2026-0538), rustls-webpki (RUSTSEC-2026-0382), webpki-roots and webpki-root-certs (RUSTSEC-2026-0381, -0383), and the unsound notices for tokio (RUSTSEC-2026-0386) and rustix (RUSTSEC-2026-0486). clipboard-win 5.4.1 was yanked; 5.4.3 replaces it.
Both now resolve to zip 9.7, which clears the zip extraction advisories (RUSTSEC-2026-0367, -0368, -0369, -0429, -0545, -0546, -0547, -0548) that the two older zip lines carried, and RUSTSEC-2026-0436 in calamine itself. No code change is needed in rustasea-excel.
jsonwebtoken 10 and p256 0.13 pulled elliptic-curve 0.13 and with it crypto-bigint 0.5, which has no patched release for RUSTSEC-2026-0387. The new lines resolve to crypto-bigint 0.7. API changes this absorbs: - EncodingKey::from_secret and DecodingKey::from_secret now return a Result. A secret the constructor rejects surfaces as AuthError::Token when signing and AuthError::InvalidToken when verifying. - The passkey tests build their signing key from fixed bytes instead of SigningKey::random, whose RNG bound changed, and use to_sec1_point. rustasea-google keeps its test-only rsa 0.9 dev-dependency: 0.9 is still in the lock through sqlx-mysql, and 0.10 needs a different RNG.
… away - RUSTSEC-2026-0459 (SQLite bundled by libsqlite3-sys): sqlx 0.8 pins libsqlite3-sys 0.30 and sqlx 0.9 declares rust-version 1.94, above the workspace MSRV of 1.88. Exposure needs an untrusted database file opened together with its -wal. - RUSTSEC-2026-0543 and RUSTSEC-2026-0555: chrono and chrono-tz are flagged unmaintained, not vulnerable. Replacing them is a migration of its own. - RUSTSEC-2023-0071 stays, with its reason corrected: rsa 0.10 is patched and the 0.9 line now remains only through sqlx-mysql and a test dependency. SECURITY.md lists the same exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo-auditandcargo-denyfail onmaster: 28 RustSec vulnerability findings, two unsound notices, two unmaintained notices, and one yanked crate have accumulated since the last green run. This PR clears them. It is based onmasterand does not depend on #7.27 of the 28 findings are fixed by upgrading. The last one cannot be upgraded away under the current MSRV, so it is recorded as an exception together with the two unmaintained notices. Those three exceptions are a risk decision and need your call (see "Exceptions").
Changes
chore(deps): update the lockfile for patched and un-yanked dependenciescrypto-bigint0.7,ctutils,quinn-proto,quinn-udp,rustls-webpki,webpki-roots,webpki-root-certs,tokio, andrustix;clipboard-win5.4.1 (yanked) becomes 5.4.3.chore(deps): bump calamine to 0.38 and rust_xlsxwriter to 0.102zip9.7, replacing the two olderziplines that carried eight advisories. No code change inrustasea-excel.chore(deps): bump jsonwebtoken to 12 and p256 to 0.14crypto-bigint0.5, which has no patched release. Adapts the JWT guard and the passkey tests to the new APIs.chore(deny): document the advisory exceptions that cannot be upgraded awaydeny.toml,.cargo/audit.toml, andSECURITY.md.The advisory ids each commit clears are in its message.
Behaviour change
EncodingKey::from_secretandDecodingKey::from_secretreturn aResultinjsonwebtoken12. A secret the constructor rejects now surfaces asAuthError::Tokenwhen signing andAuthError::InvalidTokenwhen verifying. No public RustaSea signature changes.Exceptions
RUSTSEC-2026-0459libsqlite3-sys0.30 (bundled SQLite, CVE-2026-119375)sqlx0.8 pinslibsqlite3-sys0.30. The firstsqlxline on a patched binding, 0.9, declaresrust-version = 1.94, above the workspace MSRV of 1.88 (ADR-0001). Per the advisory, only a process that opens a database file, with its-wal, written by a less trusted party is exposed.RUSTSEC-2026-0543,RUSTSEC-2026-0555chrono,chrono-tzsqlx'schronofeature, so replacing them is a migration, not a bump.RUSTSEC-2023-0071(existing)rsa0.9rsa0.10 is patched andjsonwebtoken12 andrusshnow use it; 0.9 remains only throughsqlx-mysqland a test-only dev-dependency ofrustasea-google.The alternative to the first exception is raising the MSRV to 1.94 and moving to
sqlx0.9, which also drops thersaexception. That is a larger change than this PR and an ADR decision, so I left it out.Testing
Run on rustc 1.100.0, the toolchain CI resolves
stableto:cargo auditandcargo deny check(0.21.0) pass: advisories, bans, licenses, and sources all ok.cargo test --workspace --no-fail-fastpasses: 186 suites. The two suites that compile generated code were rerun on their own after I completed my local crate cache; they resolve offline and first failed on a crate I had not downloaded.masterand on feat: database user provider, persisted sync failures, Gemini/Bedrock, and a docs sync #7,generated_module_compiles_in_workspaceandgenerated_app_compiles_for_every_variant. Both compile a generated project offline, so they can only use the cratescargo fetchdownloaded for the lockfile, and the lockfile pinned the yankedclipboard-win5.4.1. With 5.4.3 in the lockfile they pass; thecargo teststep is green in this PR's CI run.master.What stays red on this PR
Two failures are already on
masterand are fixed in #7, not here:Format, lint & cycles: a clippy 1.100needless_boollint incrates/rustasea-validation/src/context.rs, andrustasea-storage --features sftpnot compiling againstrussh0.65.Test (workspace): its second step,cargo test -p rustasea-storage --features aws,sftp, hits the same compile error.To check that nothing else is hidden behind them, I applied this diff on top of #7 and ran
cargo xtask cithere: it passes.Not verified
cargo +1.88.0 checkwas not run locally; the dependencyrust-versioncheck above is the only evidence until the CI job reports.rustasea-storagewithsftpon this branch, for the reason above.@vheins, could you review this, in particular the three exceptions?