Repository navigation
Add roles for crate maintainers - #2884
Merged
Merged
Conversation
clarfonthey
force-pushed
the
crate-maintainers-disambig
branch
from
October 24, 2026 15:53
43b4202 to
fa5b795
Compare
Contributor
Author
clarfonthey
marked this pull request as draft
October 24, 2026 15:57
clarfonthey
force-pushed
the
crate-maintainers-disambig
branch
2 times, most recently
from
October 24, 2026 16:02
9d8be08 to
44708a0
Compare
Dry-run check results |
clarfonthey
force-pushed
the
crate-maintainers-disambig
branch
3 times, most recently
from
October 24, 2026 22:23
80a3726 to
77a58e4
Compare
NobodyXu
suggested changes
Oct 25, 2026
KodrAus
reviewed
Oct 25, 2026
clarfonthey
force-pushed
the
crate-maintainers-disambig
branch
6 times, most recently
from
October 26, 2026 17:08
edaab1b to
7758fb5
Compare
clarfonthey
marked this pull request as ready for review
October 27, 2026 00:59
Contributor
Author
|
Marking ready for review since 8472 will probably answer no additional changes, but also so we can have review/approvals. |
clarfonthey
force-pushed
the
crate-maintainers-disambig
branch
from
October 27, 2026 15:36
7758fb5 to
66f043b
Compare
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
crate-maintainers-disambig
branch
from
October 28, 2026 14:32
66f043b to
6fd2b5f
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Amanieu
approved these changes
Nov 1, 2026
jieyouxu
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds roles to the crate maintainers team which are currently entirely informative like the Council roles: the goal here is to make it clearer who exactly are the people who are explicitly maintaining which crates, without changing the permissions structure of the crate maintainers subteam (for now).
In the future, depending on feasibility, it might be useful to make it so that only people with the dedicated maintainer roles can publish new versions to the crates while everyone in the crate-maintainers subteam can merge PRs. But for now, this is just to actually collect the list of people who actually maintain these crates, which will be collected in a following comment.
The main thing that requires approval here is the decision to mark hashbrown as being under the crate maintainers subteam, so that it can have one of these roles. I figured it would not make sense to remove libs write access for the time being, so, crate maintainers is just added to the list for hashbrown.
Note: for the time being, I've decided to exclude
ferris-saysfrom the list mostly just because it feels like an odd one out, and it is simple enough we can probably bundle it under other simple/silly crates if needed. Additionally,backtraceis left out due to plans to explicitly move it intorust-lang/rust.cc @nia-e @Amanieu as libs team leads for approving the change to hashbrown + adding people to the subteam, which I suspect will be non-controversial.
Full list of changes needing approval:
crate-maintainers = "write"tohashbrowncrate-maintainersNote that I've already double-checked with moderation that adding new people to T-all is okay, so, we just need an approval from libs on the new team members.