Skip to content

Add roles for crate maintainers - #2884

Merged
jieyouxu merged 1 commit into
rust-lang:mainfrom
clarfonthey:crate-maintainers-disambig
Nov 1, 2026
Merged

jieyouxu merged 1 commit into
rust-lang:mainfrom
clarfonthey:crate-maintainers-disambig

Conversation

@clarfonthey

@clarfonthey clarfonthey commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

This adds roles to the crate maintainers team which are currently entirely informative like the Council roles: the goal here is to make it clearer who exactly are the people who are explicitly maintaining which crates, without changing the permissions structure of the crate maintainers subteam (for now).

In the future, depending on feasibility, it might be useful to make it so that only people with the dedicated maintainer roles can publish new versions to the crates while everyone in the crate-maintainers subteam can merge PRs. But for now, this is just to actually collect the list of people who actually maintain these crates, which will be collected in a following comment.

The main thing that requires approval here is the decision to mark hashbrown as being under the crate maintainers subteam, so that it can have one of these roles. I figured it would not make sense to remove libs write access for the time being, so, crate maintainers is just added to the list for hashbrown.

Note: for the time being, I've decided to exclude ferris-says from the list mostly just because it feels like an odd one out, and it is simple enough we can probably bundle it under other simple/silly crates if needed. Additionally, backtrace is left out due to plans to explicitly move it into rust-lang/rust.

cc @nia-e @Amanieu as libs team leads for approving the change to hashbrown + adding people to the subteam, which I suspect will be non-controversial.

Full list of changes needing approval:

  • Adding crate-maintainers = "write" to hashbrown
  • Adding @clarfonthey (hashbrown), @cuviper (hashbrown), @Darksonn (socket2), @Thomasdezeeuw (log/socket2), @sdroege (pkg-config) to crate-maintainers
  • Removing individuals from log, pkg-config, socket repos (ones who didn't contribute within last 2 years are excluded from being re-added to list)

Note that I've already double-checked with moderation that adding new people to T-all is okay, so, we just need an approval from libs on the new team members.

@clarfonthey
clarfonthey force-pushed the crate-maintainers-disambig branch from 43b4202 to fa5b795 Compare October 24, 2026 15:53
@clarfonthey

clarfonthey commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor Author

So how this will work: essentially, since crate maintainers is intentionally a small group of people who technically are comfortable knowing that anyone else can merge changes to any of these crates, I've decided that assigning people to crates should be done just by people choosing which crates they feel most comfortable putting their name on. So, I'm going to put a bulletted list of people for everyone to check that they've chosen which crates to assign to them, and there will be a list of crates for each person.


EDIT: I completely forget that I have tried this before and it doesn't work since most people can't edit comments on this repo. Just comment here or on Zulip (#t-libs/crates > Disambiguating the crate maintainers subteam) and I'll update your list.

Acknowledgements

@clarfonthey
clarfonthey marked this pull request as draft October 24, 2026 15:57
@clarfonthey
clarfonthey force-pushed the crate-maintainers-disambig branch 2 times, most recently from 9d8be08 to 44708a0 Compare October 24, 2026 16:02
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github
[INFO  rust_team::sync] Rate limits before: REST 15000/15000 remaining, resets at 2026-10-28 15:40:11 UTC, GraphQL 12500/12500 remaining, resets at 2026-10-28 15:40:11 UTC
[INFO  rust_team::sync] 💻 Team Diffs:
    📝 Editing team 'rust-lang/crate-maintainers':
      Adding member 'Darksonn' with member role
      Adding member 'Thomasdezeeuw' with member role
      Adding member 'clarfonthey' with member role
      Adding member 'cuviper' with member role
      Adding member 'sdroege' with member role
    📝 Editing team 'rust-lang/all':
      Adding member 'Thomasdezeeuw' with member role
      Adding member 'sdroege' with member role
    💻 Repo Diffs:
    📝 Editing repo 'rust-lang/hashbrown':
      Permission Changes:
        Giving team 'crate-maintainers' write permission
    📝 Editing repo 'rust-lang/log':
      Permission Changes:
        Removing user 'Thomasdezeeuw''s maintain permission 
    📝 Editing repo 'rust-lang/pkg-config-rs':
      Permission Changes:
        Removing user 'sdroege''s write permission 
    📝 Editing repo 'rust-lang/socket2':
      Permission Changes:
        Removing user 'chansuke''s triage permission 
        Removing user 'Darksonn''s maintain permission 
        Removing user 'sfackler''s maintain permission 
        Removing user 'Thomasdezeeuw''s maintain permission 
        Removing user 'carllerche''s maintain permission 

[INFO rust_team::sync] Rate limits after: REST 13034/15000 remaining, resets at 2026-10-28 15:40:22 UTC, GraphQL 12292/12500 remaining, resets at 2026-10-28 15:40:14 UTC
[INFO rust_team::sync] Consumed 1966 REST calls and 208 GraphQL calls

@clarfonthey
clarfonthey force-pushed the crate-maintainers-disambig branch 3 times, most recently from 80a3726 to 77a58e4 Compare October 24, 2026 22:23
Comment thread teams/crate-maintainers.toml Resolved
Comment thread teams/crate-maintainers.toml Resolved
@clarfonthey
clarfonthey force-pushed the crate-maintainers-disambig branch 6 times, most recently from edaab1b to 7758fb5 Compare October 26, 2026 17:08
@clarfonthey
clarfonthey marked this pull request as ready for review October 27, 2026 00:59
@clarfonthey

Copy link
Copy Markdown
Contributor Author

Marking ready for review since 8472 will probably answer no additional changes, but also so we can have review/approvals.

@clarfonthey
clarfonthey force-pushed the crate-maintainers-disambig branch from 7758fb5 to 66f043b Compare October 27, 2026 15:36
@rustbot

This comment has been minimized.

@clarfonthey
clarfonthey force-pushed the crate-maintainers-disambig branch from 66f043b to 6fd2b5f Compare October 28, 2026 14:32
@rustbot

rustbot commented Oct 28, 2026

Copy link
Copy Markdown

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jieyouxu jieyouxu left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes broadly seem fine; this needs an approval from one of the libs co-leads though because of subteam membership changes. team-repo-admins can approve then.

cc @Amanieu @nia-e

@jieyouxu
jieyouxu added this pull request to the merge queue Nov 1, 2026
Merged via the queue into rust-lang:main with commit feecb4c Nov 1, 2026
5 checks passed
@clarfonthey
clarfonthey deleted the crate-maintainers-disambig branch November 1, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants