Skip to content

chore: upgrade github actions and fix workflow warnings - #53

Merged
rrbe merged 2 commits into
masterfrom
chore/upgrade-github-actions
Oct 13, 2026
Merged

rrbe merged 2 commits into
masterfrom
chore/upgrade-github-actions

Conversation

@rrbe

@rrbe rrbe commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

Existing workflows report Node.js action-runtime deprecation, missing Go cache dependency files, and Ubuntu runner migration warnings. Update the action versions and runner selection, and point Go caching at the server module.

  • Upgrade CI setup-node from v4 to v7 and use Node.js 24 for documentation builds.
  • Use pnpm/action-setup v6.1.0 consistently in CI and documentation deployment.
  • Set cache-dependency-path to server/go.mod in all three setup-go steps.
  • Use ubuntu-26.04 for Linux CI and documentation jobs.

Validation

  • actionlint passed with a temporary configuration registering ubuntu-26.04, which the installed version does not yet recognize.
  • git diff --check passed.
  • Hosted CI passed on commit 3efac5b: documentation, Go server, and the complete macOS smoke job including Release tests (run). Documentation deployment and release workflows retain their existing triggers and are not exercised by the PR.

CI reliability

The macOS job exposed an XCTest task-context crash and a timing-dependent share-rotation test. Run the MainActor credential-marker test asynchronously so its objects remain in XCTest’s async task context. Rotate the share at an explicit authenticated request boundary instead of using a 1.5 MB URI to delay routing. The regression still verifies file reads, uploads, old-token rejection, and new-token access across rotation.

  • Complete Debug test suite passed: 105 tests.
  • Release remote-sharing suite passed 12 consecutive runs after the actor-lifecycle change.
  • Release CI test selection passed locally: 31 tests.
  • Mutation verification: rereading the current share after authentication fails both read and upload isolation assertions; restoring the snapshot implementation passes.

@rrbe
rrbe merged commit c5d5c90 into master Oct 13, 2026
3 checks passed
@rrbe
rrbe deleted the chore/upgrade-github-actions branch October 13, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant