Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Data tabs now have a context menu and can be pinned for comparison across query runs.
The menu targets the clicked result and uses the shared menu component and localized labels. A pinned result displays a pin icon, hides its close button, and is preserved by middle-click, menu close actions, and automatic eviction. Unpin through the menu or by clicking the pin icon. Close actions are disabled when their target range contains only pinned results.
Each query retains its pinned results plus the latest eight unpinned results. Unpinning makes a result eligible for closing and eviction on the next run. Closing the owning Query tab still releases all its results. The Data tab strip also appears for a single result so it can be pinned immediately.
Evidence
pnpm typecheckpassed.pnpm exec vitest run test/unit/renderer/tabs.test.ts test/unit/renderer/appStoreTabs.test.tspassed: 2 files, 74 tests. Added coverage for pinned retention, eviction after reordering/unpinning, close protection, and result-resource release when the owning query closes.git diff --checkpassed.Merge Danger
Door: Two-way; renderer state and UI changes can be reverted.
Blast Radius: Data-tabs. Pinned results retain their resources for the owning query's lifetime and are excluded from the eight-result automatic retention limit. Query tabs retain their existing close behavior.