Repository navigation
fix(fetch): run at most 8 upstream fetches at once - #532
Draft
roschaefer wants to merge 1 commit into
Draft
roschaefer wants to merge 1 commit into
roschaefer wants to merge 1 commit into
Conversation
fetch started one git fetch per distinct upstream URL, all at the same moment. With many splices on one self-hosted server behind OpenSSH, the default MaxStartups 10:30:100 makes sshd drop unauthenticated connections at random once more than 10 are open, so some fetches failed at random and pull skipped those splices. 8 stays under that threshold while keeping fetches parallel. It is fixed rather than configurable: Git's own fetch.parallel defaults to 1, so reusing that name would either make every fetch sequential or give it a meaning that differs from Git's. A fetch thread that panicked also left its splices reported as fetched, with nothing printed; they now count as failed, like a failed fetch.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetch started one git fetch per distinct upstream URL, all at the same
moment. With many splices on one self-hosted server behind OpenSSH, the
default MaxStartups 10:30:100 makes sshd drop unauthenticated
connections at random once more than 10 are open, so some fetches
failed at random and pull skipped those splices. 8 stays under that
threshold while keeping fetches parallel. It is fixed rather than
configurable: Git's own fetch.parallel defaults to 1, so reusing that
name would either make every fetch sequential or give it a meaning that
differs from Git's.
A fetch thread that panicked also left its splices reported as fetched,
with nothing printed; they now count as failed, like a failed fetch.
Fixes #180