Skip to content

docs(scenarios): show a monorepo commit in .splice leaking history - #531

Draft
roschaefer wants to merge 1 commit into
mainfrom
docs/7-known-bug-synced-commit-leak
Draft

roschaefer wants to merge 1 commit into
mainfrom
docs/7-known-bug-synced-commit-leak

Conversation

@roschaefer

Copy link
Copy Markdown
Owner

The rebuild takes splice.commit from .splice as the parent of what
a push sends, and only checks that the commit exists. If an edit of
.splice names a monorepo commit there, the next push publishes the
monorepo's history, files outside the splice included. The fix is
postponed: every check of "belongs to the upstream's history" either
costs a history walk on every command or refuses legitimate synced
commits that no fetched branch has, such as ones fetched by id after
the upstream deleted or rewrote its branch, or remade ones.

Until then, the known-bug page records what happens today, so users
see the risk of hand-editing .splice and the page changes when the
fix lands. scenario_up_to_date takes an optional URL, so .splice can
be shown whole with a URL and ids that stay the same on every run.

Part of #7

The rebuild takes `splice.commit` from `.splice` as the parent of what
a push sends, and only checks that the commit exists. If an edit of
`.splice` names a monorepo commit there, the next push publishes the
monorepo's history, files outside the splice included. The fix is
postponed: every check of "belongs to the upstream's history" either
costs a history walk on every command or refuses legitimate synced
commits that no fetched branch has, such as ones fetched by id after
the upstream deleted or rewrote its branch, or remade ones.

Until then, the known-bug page records what happens today, so users
see the risk of hand-editing `.splice` and the page changes when the
fix lands. scenario_up_to_date takes an optional URL, so `.splice` can
be shown whole with a URL and ids that stay the same on every run.

Part of #7
@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 396e7132-14f4-46f8-98ea-e9d7e218ebcb
Commits

Reviewing files that changed from the base of the PR and between cb3f483 and 0027a65.

Files ignored due to path filters: 1

  • docs/09-scenarios/01-everyday-sync/02-up-to-date/monorepo-history-pushed.drawio.svg is excluded by !**/*.svg
Files selected for processing: 4

  • docs/09-scenarios/01-everyday-sync/02-up-to-date/monorepo-commit-as-synced-commit.md
  • docs/09-scenarios/01-everyday-sync/02-up-to-date/setup.bash
  • docs/09-scenarios/99-known-bugs.md
  • docs/09-scenarios/README.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant