Repository navigation
docs(scenarios): show a monorepo commit in .splice leaking history - #531
Draft
roschaefer wants to merge 1 commit into
Draft
roschaefer wants to merge 1 commit into
roschaefer wants to merge 1 commit into
Conversation
The rebuild takes `splice.commit` from `.splice` as the parent of what a push sends, and only checks that the commit exists. If an edit of `.splice` names a monorepo commit there, the next push publishes the monorepo's history, files outside the splice included. The fix is postponed: every check of "belongs to the upstream's history" either costs a history walk on every command or refuses legitimate synced commits that no fetched branch has, such as ones fetched by id after the upstream deleted or rewrote its branch, or remade ones. Until then, the known-bug page records what happens today, so users see the risk of hand-editing `.splice` and the page changes when the fix lands. scenario_up_to_date takes an optional URL, so `.splice` can be shown whole with a URL and ids that stay the same on every run. Part of #7
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rebuild takes
splice.commitfrom.spliceas the parent of whata push sends, and only checks that the commit exists. If an edit of
.splicenames a monorepo commit there, the next push publishes themonorepo's history, files outside the splice included. The fix is
postponed: every check of "belongs to the upstream's history" either
costs a history walk on every command or refuses legitimate synced
commits that no fetched branch has, such as ones fetched by id after
the upstream deleted or rewrote its branch, or remade ones.
Until then, the known-bug page records what happens today, so users
see the risk of hand-editing
.spliceand the page changes when thefix lands. scenario_up_to_date takes an optional URL, so
.splicecanbe shown whole with a URL and ids that stay the same on every run.
Part of #7