Skip to content

fix(clone): stop promising the first push creates the missing branch - #530

Draft
roschaefer wants to merge 1 commit into
mainfrom
fix/273-clone-first-push-message
Draft

roschaefer wants to merge 1 commit into
mainfrom
fix/273-clone-first-push-message

Conversation

@roschaefer

Copy link
Copy Markdown
Owner

On a branch upstream lacks, clone said "your first push creates
'feature'". Since #152 a push only creates the branch once a PR from it
to upstream's default branch would show changes; a push right after the
clone says "nothing to push" and creates nothing.

The clone message now only states the fact, which branch it uses. When
the branch appears depends on later work, so it doesn't belong in a
one-time message; push and status say it when it matters. The help
text says the condition, in the words push's help uses.

Fixes #273

On a branch upstream lacks, clone said "your first push creates
'feature'". Since #152 a push only creates the branch once a PR from it
to upstream's default branch would show changes; a push right after the
clone says "nothing to push" and creates nothing.

The clone message now only states the fact, which branch it uses. When
the branch appears depends on later work, so it doesn't belong in a
one-time message; push and status say it when it matters. The help
text says the condition, in the words push's help uses.

Fixes #273
@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aff129c6-3e0c-460f-bf0b-d58aa3bcb8e1
Commits

Reviewing files that changed from the base of the PR and between cb3f483 and b69db67.

Files selected for processing: 6

  • docs/05-comparisons/02-third-party/01-git-subrepo.md
  • docs/06-command-reference/01-clone.md
  • docs/09-scenarios/02-starting-a-splice/03-clone-on-feature-branch/README.md
  • docs/tests/clone.bats
  • src/clone.rs
  • src/usage/clone.txt
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clone: "your first push creates 'feature'" isn't true until the splice has a commit upstream's main lacks

1 participant