Skip to content

feat(config): warn about unknown keys in .splice - #528

Draft
roschaefer wants to merge 2 commits into
mainfrom
feat/436-unknown-keys
Draft

roschaefer wants to merge 2 commits into
mainfrom
feat/436-unknown-keys

Conversation

@roschaefer

Copy link
Copy Markdown
Owner

A misspelled key in .splice, e.g. upstream.origin.defualt-branch, was skipped without a word, so the setting seemed to be ignored for no reason: the splice followed the monorepo's branch instead of the one the file was meant to name.

Each command that reads a .splice now prints one warning per unknown key, listing the keys the file can have, and goes on as before. A typo shows up in the command that hits it, as an unknown placeholder in --message-template already does. The warning states facts only: it names the keys and doesn't guess which one was meant. A key is warned about once per command, though nested pulls read a .splice again.

.spliceconfig (#435) doesn't exist yet, so this covers .splice only.

Part of #436

A misspelled key in .splice, e.g. upstream.origin.defualt-branch, was
skipped without a word, so the setting seemed to be ignored for no
reason: the splice followed the monorepo's branch instead of the one the
file was meant to name.

Each command that reads a .splice now prints one warning per unknown
key, listing the keys the file can have, and goes on as before. A typo
shows up in the command that hits it, as an unknown placeholder in
--message-template already does. The warning states facts only: it
names the keys and doesn't guess which one was meant. A key is warned
about once per command, though nested pulls read a .splice again.

.spliceconfig (#435) doesn't exist yet, so this covers .splice only.
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: eefec98f-cb11-4620-ae42-8957ab0d4e7a
Commits

Reviewing files that changed from the base of the PR and between cb3f483 and ff7121d.

Files ignored due to path filters: 2

  • docs/09-scenarios/04-upstreams/01-default-branch/misspelled-key-after.drawio.svg is excluded by !**/*.svg
  • docs/09-scenarios/04-upstreams/01-default-branch/misspelled-key-before.drawio.svg is excluded by !**/*.svg
Files selected for processing: 5

  • docs/03-concepts/README.md
  • docs/09-scenarios/04-upstreams/01-default-branch/misspelled-key.md
  • docs/09-scenarios/README.md
  • docs/tests/upstreams.bats
  • src/repo.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

…ith git config

Every scenario page shows its first and last state as a checked drawing,
so the page now has one before the typo, where T is master, and one
after, where the splice has no T. The typo is made with git config, a
command a reader would run, instead of sed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant