Repository navigation
feat(config): warn about unknown keys in .splice - #528
Draft
roschaefer wants to merge 2 commits into
Draft
roschaefer wants to merge 2 commits into
roschaefer wants to merge 2 commits into
Conversation
A misspelled key in .splice, e.g. upstream.origin.defualt-branch, was skipped without a word, so the setting seemed to be ignored for no reason: the splice followed the monorepo's branch instead of the one the file was meant to name. Each command that reads a .splice now prints one warning per unknown key, listing the keys the file can have, and goes on as before. A typo shows up in the command that hits it, as an unknown placeholder in --message-template already does. The warning states facts only: it names the keys and doesn't guess which one was meant. A key is warned about once per command, though nested pulls read a .splice again. .spliceconfig (#435) doesn't exist yet, so this covers .splice only.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…ith git config Every scenario page shows its first and last state as a checked drawing, so the page now has one before the typo, where T is master, and one after, where the splice has no T. The typo is made with git config, a command a reader would run, instead of sed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A misspelled key in
.splice, e.g.upstream.origin.defualt-branch, was skipped without a word, so the setting seemed to be ignored for no reason: the splice followed the monorepo's branch instead of the one the file was meant to name.Each command that reads a
.splicenow prints one warning per unknown key, listing the keys the file can have, and goes on as before. A typo shows up in the command that hits it, as an unknown placeholder in--message-templatealready does. The warning states facts only: it names the keys and doesn't guess which one was meant. A key is warned about once per command, though nested pulls read a.spliceagain..spliceconfig(#435) doesn't exist yet, so this covers.spliceonly.Part of #436