Repository navigation
Feature/migrate iterable to contain in any order at least values expectations to kotlin test - #2219
Draft
TomerPacific wants to merge 2 commits into
Conversation
…ctations-to-kotlin-test migrating all relevant classes
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2020
This pull request refactors and improves the test structure for "Iterable to contain in any order at least values" expectations in both the fluent and infix APIs. The main focus is on extracting shared test logic into a new abstract base class, updating test class names for consistency, and simplifying test maintenance.
Test structure refactoring and improvements:
AbstractIterableToContainInAnyOrderAtLeastValuesExpectationsTest, to consolidate and share test logic for "at least" and "at least but at most" iterable containment expectations across different API styles.IterableToContainInAnyOrderAtLeastValuesExpectationsSpectoIterableToContainInAnyOrderAtLeastValuesExpectationsTestand making it inherit from the new abstract base class. Also added a simple@Testmethod to trigger the test runner gutter. [1] [2]IterableToContainInAnyOrderAtLeastValuesExpectationsSpectoIterableToContainInAnyOrderAtLeastValuesExpectationsTestand making it inherit from the new abstract base class. Also added a simple@Testmethod to trigger the test runner gutter.These changes improve code reuse, consistency, and maintainability of the test suite for iterable containment expectations.
I ran the tests locally on a Windows machine and they passed.
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.