Repository navigation
fix-ask-conversation-hidden-by-hook-claude: run the LLM phone check outside a GUI panel's binding - #112
Merged
tarr1124 merged 1 commit intoOct 28, 2026
Conversation
The pre-commit PII hook (and `rill crypt doctor`) start `claude -p` to verify phone candidates. When the commit comes from a GUI panel's Stop hook (`rill autosync hook-stop` -> `rill push`), that child inherited the panel's RILL_TAB / RILL_WORKSPACE / RILL_ORIGIN, so `rill session-hook` recorded the check's own session as a new session of the panel. The app then took it for the panel's current conversation (as after a /clear) and dropped the real one from its list while its process kept running. The child also inherited autosync, so its SessionStart hook waited up to 60 s on the lock held by the very commit that started it. Both call sites now drop the panel binding and set RILL_AUTOSYNC=0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tarr1124
deleted the
feature/fix-ask-conversation-hidden-by-hook-claude
branch
October 28, 2026 12:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a GUI panel's turn ends, its Stop hook runs
rill autosync hook-stop, which commits through the pre-commit PII hook. If a staged line trips the phone regex, the hook startsclaude -p --model haikuto verify it. That child inherited the panel'sRILL_TAB/RILL_WORKSPACE/RILL_ORIGIN, sorill session-hookrecorded the check's own session as a new session of the panel.The app reads the newest
SessionStartwith a panel's tab as the panel's current conversation (that is how/clearis followed), so it took the check for the panel's conversation. In Ask the vault, the real conversation then left the list while its process kept running, and was unreachable after leaving and reopening Ask.The child also inherited autosync, so its own SessionStart hook waited up to 60 s on the lock held by the commit that started it.
Change
bin/hooks/pre-commit-pii-check.shandrill crypt doctorstart the check withenv -u RILL_TAB -u RILL_WORKSPACE -u RILL_ORIGIN -u RILL_CLAUDE_VERSION RILL_AUTOSYNC=0(the same panel variables the app already strips from the processes it spawns).test/cli/test-pii-hook.sh: a stubclauderecords its environment; both call sites are checked under a panel's environment. The new cases fail onmainand pass here.The app side (ignore
sdk-cliSessionStarts when binding a panel) is fixed separately in the app repository.Verification
bash test/cli/test-pii-hook.sh: 49/49bash test/cli/test-pii-regex-guard.sh: 18/18codex review --base main: no findings🤖 Generated with Claude Code