Repository navigation
fix(domains): add capabilities and create tls to domain types - #321
Open
mayankbohradev wants to merge 1 commit into
Open
mayankbohradev wants to merge 1 commit into
mayankbohradev wants to merge 1 commit into
Conversation
The API accepts `capabilities` on create and update and `tls` on create. It returns `capabilities` on create, get and list. The SDK already sends and returns these values, but the types rejected them, so mypy reported documented usage as an error. - Add `DomainCapabilities` and `DomainCapabilityStatus`. - Add `Domains.CapabilitiesParams` for create and update. - Add `capabilities` to `Domain` and `CreateDomainResponse`. - Add `tls` to `Domains.CreateParams`. Tested with tox lint, mypy and py (876 passed).
This was referenced Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the documented
capabilitiesfield to the domain create params, update params,Domainand the create response. Addstlsto the create params.Why
The API accepts and returns these fields (create, update, get, list), and the SDK already forwards them. The types rejected them, so mypy reported documented usage as an error.
How
DomainCapabilitiesandDomainCapabilityStatusdescribe the response object.Domains.CapabilitiesParamsistotal=False, because create and update accept one or both keys.capabilitiesisNotRequiredon the response types, like the other optional domain settings.Testing
tox -e lint,tox -e mypyandtox -e pypass (876 tests).Notes for reviewers
New public names:
resend.DomainCapabilities,resend.DomainCapabilityStatusandresend.Domains.CapabilitiesParams. #320 edits the same file; I can rebase after it merges.Summary by cubic
Adds the documented
capabilitiesandtlsfields to the domain types so mypy no longer rejects usage that the API already supports.capabilitiesis now accepted on create and update params and returned on create, get, and list responses.tlsis now accepted on create params.resend.DomainCapabilities,resend.DomainCapabilityStatus, andresend.Domains.CapabilitiesParams.Written for commit 6703209. Summary will update on new commits.